We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We already have the ChaosExperimentRunStatus enum like below.
ChaosExperimentRunStatus
litmus/chaoscenter/graphql/definitions/shared/chaos_experiment.graphqls
Lines 23 to 33 in 399af62
But our code base uses plain string, not an enum. That makes it difficult to make changes to the code.
e.g.
There's no Queued state in our enum.
Queued
litmus/chaoscenter/graphql/server/pkg/chaos_experiment_run/handler/handler.go
Lines 856 to 859 in 399af62
There's a difference between our enum and other code
Lines 1045 to 1051 in 399af62
Also, I cannot find docs about Chaos Experiment status & Chaos Experiment Run status.
Chaos Experiment status & Chaos Experiment Run status
So, We need to implement two things.
Let me know if I'm misinterpreting. If I'm on the right track, I'll get started or assign the task to the LFX mentee.
The text was updated successfully, but these errors were encountered:
@amityt Can you take a look at this?
Sorry, something went wrong.
Sure @Saranya-jena I will take this up! Thanks for pointing this out @namkyu1999
chore: [litmuschaos#4400]: Updated experiment run status enums and re…
2f47d67
…moved hard-coded statuses Signed-off-by: Amit Kumar Das <amit.das@harness.io>
chore: [#4400]: Updated experiment run status enums and removed hard-…
207676e
…coded statuses (#4494) Signed-off-by: Amit Kumar Das <amit.das@harness.io>
Successfully merging a pull request may close this issue.
We already have the
ChaosExperimentRunStatus
enum like below.litmus/chaoscenter/graphql/definitions/shared/chaos_experiment.graphqls
Lines 23 to 33 in 399af62
But our code base uses plain string, not an enum. That makes it difficult to make changes to the code.
e.g.
There's no
Queued
state in our enum.litmus/chaoscenter/graphql/server/pkg/chaos_experiment_run/handler/handler.go
Lines 856 to 859 in 399af62
There's a difference between our enum and other code
litmus/chaoscenter/graphql/server/pkg/chaos_experiment_run/handler/handler.go
Lines 1045 to 1051 in 399af62
Also, I cannot find docs about
Chaos Experiment status & Chaos Experiment Run status
.So, We need to implement two things.
Chaos Experiment status & Chaos Experiment Run status
Let me know if I'm misinterpreting. If I'm on the right track, I'll get started or assign the task to the LFX mentee.
The text was updated successfully, but these errors were encountered: