Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loader in all the confirm buttons of Modals under User Management #4449

Closed
Saranya-jena opened this issue Feb 19, 2024 · 6 comments · Fixed by #4452
Closed

Add loader in all the confirm buttons of Modals under User Management #4449

Saranya-jena opened this issue Feb 19, 2024 · 6 comments · Fixed by #4452
Assignees
Labels

Comments

@Saranya-jena
Copy link
Contributor

What happened:

Currently upon selecting the confirm button, the API takes some time to get resolved however there is no loader for this state which makes it a bit confusing.

What you expected to happen:

Add loader in all the confirm buttons of Modals under User Management

Where can this issue be corrected? (optional)

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

@aryan-bhokare
Copy link
Contributor

aryan-bhokare commented Feb 19, 2024

Screencast.from.19-02-24.04.20.11.PM.IST.webm

Hi @Saranya-jena will this work.
If yes I can quicky make a pr for it.

@Saranya-jena
Copy link
Contributor Author

@SahilKr24 @hrishavjha Can you confirm?

@SahilKr24
Copy link
Member

SahilKr24 commented Feb 19, 2024

@SahilKr24 @hrishavjha Can you confirm?

Seems good to me, just a minor detail, we can also have the confirm button to be disabled when the modal opens i.e. the form is empty or not touched.

@aryan-bhokare
Copy link
Contributor

@SahilKr24 @hrishavjha Can you confirm?

Seems good to me, just a minor detail, we can also have the confirm button to be disabled when the modal opens i.e. the form is empty or not touched.

@SahilKr24 ok sure let me take a look once.

@aryan-bhokare
Copy link
Contributor

aryan-bhokare commented Feb 19, 2024

@SahilKr24

image

This is how it is handled if we click on confirm when fields are empty or in wrong format.

So should I disable the button at the start? or we should keep it as it is?

@SahilKr24
Copy link
Member

@SahilKr24

image

This is how it is handled if we click on confirm when fields are empty or in wrong format.

So should I disable the button at the start? or we should keep it as it is?

This should also be fine 👍🏻

aryan-bhokare added a commit to aryan-bhokare/litmus that referenced this issue Feb 23, 2024
Signed-off-by: aryan <aryan1bhokare@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants