-
Notifications
You must be signed in to change notification settings - Fork 686
-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(ui-frontend-implementation): Adding a "JOIN US ON SLACK" button #789
Comments
@aditya109 Can I take up this issue? |
sure!! @Sweta271097 You can take up this issue |
@Sweta271097 for sure.. Comment out whatever help you need. |
Also @Sweta271097 don't forget to add this issue number in your PR, and add a link to your PR here as well. |
Can I get a chance on this one? |
Hi, are we looking to add this on homepage or on the localhost or a different site since the community link on the homepage already has it? Also, is there any specific location that we want this to appear on the site? |
Hi @sakkshm, as an open source culture, its first-come-first-serve for the open issue. If you still want to this task, you have to wait for 2 days, and if there is no PR raised, the current assignee would be relieved, and if you are still up for this task, I would gladly assign it to you. For the time being I would suggest you to take up other open issues from , it'd be great. |
Hi @mohatagarvit, we want it on this button to appear on the homepage of chart-hub. |
Can I work on this? is it Done? |
Hi @ambaresthete, actually as per open source culture it is FCFS for taking issues. So I will have to assign this @sakkshm. If he does not reply for next 2-3 hours, on his interest, I will assign this issue to you. |
@aditya109 I'll do it! |
Okay, @aditya109. I have my PR ready. Let me know if there's no response. |
@aditya109 I will not be able to do it. Kindly assign it to someone else. |
Its okay @sakkshm, take a look at other issues and give them a try. |
Hi @aditya109, can you put more description of the issue, |
@inyee786, I have updated the details in the description of this issue. |
Hi @ambaresthete, since there was no PR raised I have assigned this task to you. Please take a look at the updated details in the description and make changes if required. Also please don't forget to star the https://github.com/litmuschaos/litmus. |
@aditya109 are you sure it goes to bottom-right corner? I guess top-right corner would be appropriate, as there is no footer and it goes along with header. |
@ambaresthete there is going to be a footer in the near future. So for now if you think it looks better in the top right, raise the PR and attach a screenshot of the UI. I will ask @inyee786 to review the feel of your change and ask for his opinion on the matter as well. |
I made the PR. Check the below link: |
Available in the revamped charthub |
UI-FRONTEND-IMPLEMENTATION
What happens:
What you expected to happen:
The button goes in bottom-right corner when we open any window and should redirect to https://app.slack.com/client/T09NY5SBT/CNXNB0ZTN.
The button will look like something like this :-
https://www.stickpng.com/img/icons-logos-emojis/tech-companies/slack-new-logo-icon
Anything else we need to know?:
Issue related to Repository : https://github.com/litmuschaos/charthub.litmuschaos.io
The text was updated successfully, but these errors were encountered: