Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ui-frontend-implementation): Adding a "JOIN US ON SLACK" button #789

Closed
aditya109 opened this issue Sep 30, 2019 · 21 comments
Closed

(ui-frontend-implementation): Adding a "JOIN US ON SLACK" button #789

aditya109 opened this issue Sep 30, 2019 · 21 comments

Comments

@aditya109
Copy link

aditya109 commented Sep 30, 2019

UI-FRONTEND-IMPLEMENTATION

What happens:

  • Adding a "JOIN US ON SLACK" which directs us to slack channel

What you expected to happen:

@Sweta271097
Copy link

@aditya109 Can I take up this issue?

@chandankumar4
Copy link
Member

sure!! @Sweta271097 You can take up this issue

@aditya109
Copy link
Author

@Sweta271097 for sure.. Comment out whatever help you need.

@aditya109
Copy link
Author

Also @Sweta271097 don't forget to add this issue number in your PR, and add a link to your PR here as well.

@sakkshm
Copy link

sakkshm commented Oct 4, 2019

Can I get a chance on this one?

@mohatagarvit
Copy link

Hi, are we looking to add this on homepage or on the localhost or a different site since the community link on the homepage already has it? Also, is there any specific location that we want this to appear on the site?

@aditya109
Copy link
Author

aditya109 commented Oct 4, 2019

Can I get a chance on this one?

Hi @sakkshm, as an open source culture, its first-come-first-serve for the open issue. If you still want to this task, you have to wait for 2 days, and if there is no PR raised, the current assignee would be relieved, and if you are still up for this task, I would gladly assign it to you. For the time being I would suggest you to take up other open issues from , it'd be great.

@aditya109
Copy link
Author

aditya109 commented Oct 4, 2019

Hi, are we looking to add this on homepage or on the localhost or a different site since the community link on the homepage already has it? Also, is there any specific location that we want this to appear on the site?

Hi @mohatagarvit, we want it on this button to appear on the homepage of chart-hub.

@ambaresthete
Copy link

Can I work on this? is it Done?

@aditya109
Copy link
Author

Hi @ambaresthete, actually as per open source culture it is FCFS for taking issues. So I will have to assign this @sakkshm. If he does not reply for next 2-3 hours, on his interest, I will assign this issue to you.

@aditya109 aditya109 assigned sakkshm and unassigned Sweta271097 Oct 5, 2019
@sakkshm
Copy link

sakkshm commented Oct 5, 2019

@aditya109 I'll do it!
Will make the PR till tomorrow!

@ambaresthete
Copy link

Okay, @aditya109. I have my PR ready. Let me know if there's no response.

@sakkshm
Copy link

sakkshm commented Oct 6, 2019

@aditya109 I will not be able to do it. Kindly assign it to someone else.

@aditya109
Copy link
Author

@aditya109 I will not be able to do it. Kindly assign it to someone else.

Its okay @sakkshm, take a look at other issues and give them a try.

@aditya109 aditya109 assigned ambaresthete and unassigned sakkshm Oct 6, 2019
@inyee786
Copy link
Member

inyee786 commented Oct 6, 2019

Hi @aditya109, can you put more description of the issue,
like where the button goes in UI, what is slack URL?

@aditya109
Copy link
Author

Hi @aditya109, can you put more description of the issue,
like where the button goes in UI, what is slack URL?

@inyee786, I have updated the details in the description of this issue.

@aditya109
Copy link
Author

aditya109 commented Oct 6, 2019

Okay, @aditya109. I have my PR ready. Let me know if there's no response.

Hi @ambaresthete, since there was no PR raised I have assigned this task to you. Please take a look at the updated details in the description and make changes if required. Also please don't forget to star the https://github.com/litmuschaos/litmus.

@ambaresthete
Copy link

@aditya109 are you sure it goes to bottom-right corner? I guess top-right corner would be appropriate, as there is no footer and it goes along with header.

@aditya109
Copy link
Author

@ambaresthete there is going to be a footer in the near future. So for now if you think it looks better in the top right, raise the PR and attach a screenshot of the UI. I will ask @inyee786 to review the feel of your change and ask for his opinion on the matter as well.

@ambaresthete
Copy link

I made the PR. Check the below link:

litmuschaos/charthub.litmuschaos.io#39

@ksatchit
Copy link
Member

Available in the revamped charthub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants