Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stopped CircleCi Build for master branch #1625

Merged
merged 6 commits into from
Jul 1, 2020
Merged

Stopped CircleCi Build for master branch #1625

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3dd941e
Stopped CircleCi Build for master
gdsoumya Jun 30, 2020
fa57e5b
Update config.yml
gdsoumya Jun 30, 2020
0bb5522
Update config.yml
gdsoumya Jun 30, 2020
7b307a0
Update config.yml
gdsoumya Jun 30, 2020
8080ea3
Update config.yml
gdsoumya Jul 1, 2020
9abbeda
Update config.yml
gdsoumya Jul 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
version: 2
jobs:
build:
branches:
ignore:
- master
machine: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed !

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @ksatchit I removed each instruction and checked, every time it threw an error. I believe the current version is the minimal config that we can go for.

steps:
- checkout

# build the application image
- run: |
echo "$DPASS" | docker login --username $DUNAME --password-stdin
cd litmus-portal && make build push
Copy link
Member

@imrajdas imrajdas Jun 30, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this part

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't be a problem as the the workflow will not be executed in the master, also we need some run command or ci throws an error. I have added a simple echo as a run command.