chore(litmus-portal): Home Page Stats for Litmus Portal. #2053

ishangupta-ds · 2020-09-12T15:22:08Z

Proposed changes

Adding basic analytics for home page of litmus portal.
fixes #1788

This PR also removes two outdated test cases from the cypress test suite of PassedVsFailed component.

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

New feature (non-breaking change which adds functionality)
Bugfix (non-breaking change which fixes an issue)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

I have read the CONTRIBUTING doc
I have signed the commit for DCO to be passed.
Lint and unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added necessary documentation (if appropriate)

Dependency

None.

Special notes for your reviewer:

Analytics PR #1

Signed-off-by: ishangupta-ds <ishan.gupta@mayadata.io>

ishangupta-ds · 2020-09-12T15:28:26Z

arkajyotiMukherjee · 2020-09-12T15:23:41Z

litmus-portal/backend/auth/pkg/types/const.go

-	DefaultDBServerURL         string = os.Getenv("DB_SERVER")
+	DefaultAPISecret           string = "litmus-portal@123"
+	DefaultUserName            string = "admin"
+	DefaultUserPassword        string = "litmus"


Can you change these back

already reverted. @arkajyotiMukherjee

arkajyotiMukherjee · 2020-09-12T15:25:59Z

litmus-portal/frontend/src/components/ProgressBar/AnalyticsLinearProgressBar/index.tsx

+  const width: number = 2;
+  const resultValue = ((value as number) / (maxValue as number)) * 100;
+  useEffect(() => {
+    return setColor('#5B44BA');


why does color require to be a state variable if I never changes.
use a fixed color from theme data with useTheme()

Some components were already there just reused code from them, will make changes for this.. @arkajyotiMukherjee

arkajyotiMukherjee · 2020-09-12T15:26:15Z

litmus-portal/frontend/src/components/ProgressBar/AnalyticsLinearProgressBar/index.tsx

+  const [color, setColor] = useState(' ');
+  const width: number = 2;
+  const resultValue = ((value as number) / (maxValue as number)) * 100;
+  useEffect(() => {


This useEffect is not needed

arkajyotiMukherjee · 2020-09-12T15:33:10Z

litmus-portal/frontend/src/views/Home/PassedVsFailed/index.tsx

-                alt="Failed Icon"
+              <Avatar
+                style={{
+                  backgroundColor: '#CA2C2C',


put all colors in theme...if it is in react component use "useTheme" if it is used in styles...use normal theme value you get

arkajyotiMukherjee · 2020-09-13T04:36:54Z

/preview 20

LINK EXPIRES IN : 20mins

SVC Name	Address	Protocol
http	3.136.2.227:31114	TCP
graphql-server	3.136.2.227:30111	TCP
auth-server	3.136.2.227:30454	TCP

LINK EXPIRED

Jonsy13 · 2020-09-13T04:52:54Z

/run-unit

Test Status: The testing has been started please wait for the results ...
Test Failed: Some tests are failed please check
Run ID: 252034782

Jonsy13 · 2020-09-13T04:58:19Z

/run-unit

Test Status: The testing has been started please wait for the results ...
Test Failed: Some tests are failed please check
Run ID: 252037236

Signed-off-by: ishangupta-ds <ishan.gupta@mayadata.io>

Changes made PTAL.

Jonsy13 · 2020-09-13T06:54:12Z

/run-unit

Test Status: The testing has been started please wait for the results ...
Test Failed: Some tests are failed please check
Run ID: 252124178

Signed-off-by: ishangupta-ds <ishan.gupta@mayadata.io>

ishangupta-ds · 2020-09-13T07:08:01Z

/run-unit

Test Status: The testing has been started please wait for the results ...
Test Failed: Some tests are failed please check
Run ID: 252134477

Signed-off-by: ishangupta-ds <ishan.gupta@mayadata.io>

ishangupta-ds · 2020-09-13T07:39:10Z

/run-unit

Test Status: The testing has been started please wait for the results ...
Test Failed: Some tests are failed please check
Run ID: 252159361

Signed-off-by: ishangupta-ds <ishan.gupta@mayadata.io>

ishangupta-ds · 2020-09-13T13:15:56Z

@rajdas98 @arkajyotiMukherjee @amityt @S-ayanide all the suggested changes have been made PTAL.

ishangupta-ds · 2020-09-13T13:19:10Z

/preview 10

LINK EXPIRES IN : 10mins

SVC Name	Address	Protocol
http	3.136.2.227:30720	TCP
graphql-server	3.136.2.227:32640	TCP
auth-server	3.136.2.227:32324	TCP

LINK EXPIRED

S-ayanide · 2020-09-13T13:21:05Z

litmus-portal/frontend/package.json

@@ -17,6 +17,7 @@
    "@material-ui/core": "^4.10.2",
    "@material-ui/icons": "^4.9.1",
    "@material-ui/pickers": "^3.2.10",
+    "@types/lodash": "^4.14.161",


I believe this should be a dev dependency

S-ayanide · 2020-09-13T13:24:00Z

litmus-portal/frontend/src/views/Home/AverageResilienceScore/index.tsx

+/*
+  Reusable Semi Circular Progress Bar
+  Required Params: value
+*/


Remove this comment, doesn't make sense in this context

S-ayanide · 2020-09-13T13:26:25Z

This PR looks good to me, just a very minor change. 👍

arkajyotiMukherjee · 2020-09-13T08:09:46Z

litmus-portal/frontend/src/views/Home/ReturningHome/index.tsx

+    WORKFLOW_DETAILS,
+    {
+      variables: { projectID: userData.selectedProjectID },
+      fetchPolicy: 'cache-and-network',


remove fetch policy

Removed @arkajyotiMukherjee

arkajyotiMukherjee · 2020-09-13T13:25:47Z

litmus-portal/frontend/cypress/component/passedVsFailed.spec.tsx

-  it('Pass Icon is present', () => {
-    mount(wrapper);
-    cy.get('[data-cy=passIcon]')
-      .should('have.attr', 'src')


did we plan on removing all test cases @Jonsy13 @S-ayanide

yeah we are not using these icons i am using the available icons in material ui as they are same, and moreover pngs were used earlier which were getting blurred... so these conditions will always fail @arkajyotiMukherjee cc: @Jonsy13 @S-ayanide

No @arkajyotiMukherjee It's not decided.Tests will remain.

without icons how do i make the old test cases pass? @Jonsy13 @arkajyotiMukherjee

@ishangupta-ds Can we add the two tests but instead use you Avatar icon and other icons from MUI itself? If that's possible for now!

Yes @S-ayanide That should be good.

It is not accessible as png now we have to check for the material icon, i have another PR pending for the analytics, will be adding test cases after this release @S-ayanide @Jonsy13 ..if it is good?

S-ayanide · 2020-09-13T13:41:05Z

/run-unit

Test Status: The testing has been started please wait for the results ...
Test Failed: Some tests are failed please check
Run ID: 252445349

Signed-off-by: ishangupta-ds <ishan.gupta@mayadata.io>

ishangupta-ds · 2020-09-13T13:42:16Z

@arkajyotiMukherjee @S-ayanide @Jonsy13 @rajdas98 PTAL.

…#2053) This commit removes two outdated test cases from the cypress test suite of PassedVsFailed component Signed-off-by: ishangupta-ds <ishan.gupta@mayadata.io>

ishangupta-ds added 4 commits September 12, 2020 13:37

Home Page Analytics Frontend.

db63e7e

Signed-off-by: ishangupta-ds <ishan.gupta@mayadata.io>

Resolved conflicts.

b80d8d7

Signed-off-by: ishangupta-ds <ishan.gupta@mayadata.io>

Home Page Analytics Integration.

8a22aa2

Signed-off-by: ishangupta-ds <ishan.gupta@mayadata.io>

Resolved conflicts.

13b91c2

Signed-off-by: ishangupta-ds <ishan.gupta@mayadata.io>

ishangupta-ds added the area/litmus-portal label Sep 12, 2020

ishangupta-ds added this to the 1.8 milestone Sep 12, 2020

ishangupta-ds requested review from imrajdas, ajeshbaby, arkajyotiMukherjee and gdsoumya September 12, 2020 15:22

ishangupta-ds self-assigned this Sep 12, 2020

Removed auth changes.

8e6a494

Signed-off-by: ishangupta-ds <ishan.gupta@mayadata.io>

arkajyotiMukherjee previously requested changes Sep 12, 2020

View reviewed changes

arkajyotiMukherjee added the DO NOT MERGE label Sep 13, 2020

ishangupta-ds added 2 commits September 13, 2020 11:02

Changes after review.

580cbc9

Signed-off-by: ishangupta-ds <ishan.gupta@mayadata.io>

Merge remote-tracking branch 'upstream/master' into browse-analytics

e4a2c7d

ishangupta-ds requested a review from arkajyotiMukherjee September 13, 2020 05:34

ishangupta-ds requested review from amityt and Jonsy13 September 13, 2020 06:49

ishangupta-ds added 2 commits September 13, 2020 12:26

Updating test case for quick actions card.

6e76f57

Signed-off-by: ishangupta-ds <ishan.gupta@mayadata.io>

Updating test case for updated components.

3c6d235

Signed-off-by: ishangupta-ds <ishan.gupta@mayadata.io>

Updating test case for passed vs failed.

3589c63

Signed-off-by: ishangupta-ds <ishan.gupta@mayadata.io>

ishangupta-ds added state/review-in-progress WIP and removed DO NOT MERGE labels Sep 13, 2020

ishangupta-ds added 2 commits September 13, 2020 17:41

Merge remote-tracking branch 'upstream/master' into browse-analytics

290799e

Changes after review.

c27deb1

Signed-off-by: ishangupta-ds <ishan.gupta@mayadata.io>

ishangupta-ds added state/design-complete state/dev-complete priority/high and removed WIP labels Sep 13, 2020

S-ayanide requested changes Sep 13, 2020

View reviewed changes

arkajyotiMukherjee reviewed Sep 13, 2020

View reviewed changes

Changes after review.

68d41fd

Signed-off-by: ishangupta-ds <ishan.gupta@mayadata.io>

ishangupta-ds requested review from S-ayanide and arkajyotiMukherjee September 13, 2020 13:41

S-ayanide approved these changes Sep 13, 2020

View reviewed changes

arkajyotiMukherjee approved these changes Sep 13, 2020

View reviewed changes

Jonsy13 approved these changes Sep 13, 2020

View reviewed changes

ishangupta-ds added merge state/review-complete and removed state/review-in-progress labels Sep 13, 2020

arkajyotiMukherjee removed priority/high merge labels Sep 13, 2020

ishangupta-ds added the merge label Sep 13, 2020

imrajdas merged commit 1199ab3 into litmuschaos:master Sep 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(litmus-portal): Home Page Stats for Litmus Portal. #2053

chore(litmus-portal): Home Page Stats for Litmus Portal. #2053

ishangupta-ds commented Sep 12, 2020 •

edited

Loading

ishangupta-ds commented Sep 12, 2020

arkajyotiMukherjee Sep 12, 2020

ishangupta-ds Sep 12, 2020

arkajyotiMukherjee Sep 12, 2020

ishangupta-ds Sep 12, 2020

arkajyotiMukherjee Sep 12, 2020

arkajyotiMukherjee Sep 12, 2020

arkajyotiMukherjee commented Sep 13, 2020 •

edited by imrajdas

Loading

Jonsy13 commented Sep 13, 2020 •

edited by github-actions bot

Loading

Jonsy13 commented Sep 13, 2020 •

edited by github-actions bot

Loading

Jonsy13 commented Sep 13, 2020 •

edited by github-actions bot

Loading

ishangupta-ds commented Sep 13, 2020 •

edited by github-actions bot

Loading

ishangupta-ds commented Sep 13, 2020 •

edited by github-actions bot

Loading

ishangupta-ds commented Sep 13, 2020 •

edited

Loading

ishangupta-ds commented Sep 13, 2020 •

edited by imrajdas

Loading

S-ayanide Sep 13, 2020

S-ayanide Sep 13, 2020

S-ayanide commented Sep 13, 2020 •

edited

Loading

arkajyotiMukherjee Sep 13, 2020

ishangupta-ds Sep 13, 2020

arkajyotiMukherjee Sep 13, 2020

ishangupta-ds Sep 13, 2020 •

edited

Loading

Jonsy13 Sep 13, 2020

ishangupta-ds Sep 13, 2020

S-ayanide Sep 13, 2020

Jonsy13 Sep 13, 2020

ishangupta-ds Sep 13, 2020

S-ayanide commented Sep 13, 2020 •

edited by github-actions bot

Loading

ishangupta-ds commented Sep 13, 2020

chore(litmus-portal): Home Page Stats for Litmus Portal. #2053

chore(litmus-portal): Home Page Stats for Litmus Portal. #2053

Conversation

ishangupta-ds commented Sep 12, 2020 • edited Loading

Proposed changes

Types of changes

Checklist

Dependency

Special notes for your reviewer:

ishangupta-ds commented Sep 12, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arkajyotiMukherjee commented Sep 13, 2020 • edited by imrajdas Loading

Jonsy13 commented Sep 13, 2020 • edited by github-actions bot Loading

Jonsy13 commented Sep 13, 2020 • edited by github-actions bot Loading

Jonsy13 commented Sep 13, 2020 • edited by github-actions bot Loading

ishangupta-ds commented Sep 13, 2020 • edited by github-actions bot Loading

ishangupta-ds commented Sep 13, 2020 • edited by github-actions bot Loading

ishangupta-ds commented Sep 13, 2020 • edited Loading

ishangupta-ds commented Sep 13, 2020 • edited by imrajdas Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

S-ayanide commented Sep 13, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ishangupta-ds Sep 13, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

S-ayanide commented Sep 13, 2020 • edited by github-actions bot Loading

ishangupta-ds commented Sep 13, 2020

ishangupta-ds commented Sep 12, 2020 •

edited

Loading

arkajyotiMukherjee commented Sep 13, 2020 •

edited by imrajdas

Loading

Jonsy13 commented Sep 13, 2020 •

edited by github-actions bot

Loading

Jonsy13 commented Sep 13, 2020 •

edited by github-actions bot

Loading

Jonsy13 commented Sep 13, 2020 •

edited by github-actions bot

Loading

ishangupta-ds commented Sep 13, 2020 •

edited by github-actions bot

Loading

ishangupta-ds commented Sep 13, 2020 •

edited by github-actions bot

Loading

ishangupta-ds commented Sep 13, 2020 •

edited

Loading

ishangupta-ds commented Sep 13, 2020 •

edited by imrajdas

Loading

S-ayanide commented Sep 13, 2020 •

edited

Loading

ishangupta-ds Sep 13, 2020 •

edited

Loading

S-ayanide commented Sep 13, 2020 •

edited by github-actions bot

Loading