Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(litmus-portal): Add units to AddProbe modal #2731

Merged
merged 2 commits into from
Apr 26, 2021
Merged

chore(litmus-portal): Add units to AddProbe modal #2731

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee497c3
Add units to AddProbe modal
saswatamcode Apr 21, 2021
9aa7e17
Add translation
saswatamcode Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion litmus-portal/frontend/src/views/CreateWorkflow/TuneWorkflow/AddProbe/ProbeDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ const ProbeDetails: React.FC<ProbeDetailsProps> = ({
</div>
<div className={classes.formField}>
<InputLabel className={classes.formLabel} htmlFor="responseTimeout">
Response Timeout
Response Timeout(ms)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any specific use-case for not using translation here? @saswatamcode

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Adding it into translation file!

</InputLabel>
<InputField
variant="primary"
Expand Down
9 changes: 5 additions & 4 deletions litmus-portal/frontend/src/views/CreateWorkflow/TuneWorkflow/AddProbe/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ const AddProbe: React.FC<AddProbeProps> = ({
<div className={classes.detailContainer}>
<div className={classes.formField}>
<InputLabel className={classes.formLabel} htmlFor="timeout">
{t('createWorkflow.tuneWorkflow.addProbe.labels.timeout')}
{t('createWorkflow.tuneWorkflow.addProbe.labels.timeout')}(ms)
</InputLabel>
<InputField
variant="primary"
Expand All @@ -210,7 +210,7 @@ const AddProbe: React.FC<AddProbeProps> = ({
</div>
<div className={classes.formField}>
<InputLabel className={classes.formLabel} htmlFor="retry">
{t('createWorkflow.tuneWorkflow.addProbe.labels.retry')}
{t('createWorkflow.tuneWorkflow.addProbe.labels.retry')}(times)
</InputLabel>
<InputField
variant="primary"
Expand All @@ -226,7 +226,7 @@ const AddProbe: React.FC<AddProbeProps> = ({
<div className={classes.detailContainer}>
<div className={classes.formField}>
<InputLabel className={classes.formLabel} htmlFor="interval">
{t('createWorkflow.tuneWorkflow.addProbe.labels.interval')}
{t('createWorkflow.tuneWorkflow.addProbe.labels.interval')}(ms)
</InputLabel>
<InputField
variant="primary"
Expand All @@ -240,7 +240,7 @@ const AddProbe: React.FC<AddProbeProps> = ({
</div>
<div className={classes.formField}>
<InputLabel className={classes.formLabel} htmlFor="polling">
{t('createWorkflow.tuneWorkflow.addProbe.labels.polling')}
{t('createWorkflow.tuneWorkflow.addProbe.labels.polling')}(ms)
</InputLabel>
<InputField
variant="primary"
Expand All @@ -256,6 +256,7 @@ const AddProbe: React.FC<AddProbeProps> = ({
<div className={classes.formField}>
<InputLabel className={classes.formLabel} htmlFor="initial-delay">
{t('createWorkflow.tuneWorkflow.addProbe.labels.initialDelay')}
(ms)
</InputLabel>
<InputField
variant="primary"
Expand Down
4 changes: 2 additions & 2 deletions litmus-portal/frontend/src/views/CreateWorkflow/TuneWorkflow/AddProbe/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const useStyles = makeStyles((theme) => ({
detailContainer: {
display: 'flex',
gap: '1rem',
width: '90%',
width: '100%',
},
form: {
alignItems: 'left',
Expand All @@ -25,7 +25,7 @@ const useStyles = makeStyles((theme) => ({
gap: '0.5rem',
justifyContent: 'space-evenly',
marginTop: theme.spacing(2),
width: '80%',
width: '90%',
},
formField: {
alignItems: 'center',
Expand Down