Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Moving pagination, sorting and filtering of workflow runs table to the backend #2829

Merged
merged 26 commits into from
Jun 7, 2021
Merged

Enhancement: Moving pagination, sorting and filtering of workflow runs table to the backend #2829

merged 26 commits into from
Jun 7, 2021

Conversation

arkajyotiMukherjee
Copy link
Contributor

@arkajyotiMukherjee arkajyotiMukherjee commented May 21, 2021 •
edited
Loading

Proposed changes

Improvements:

  • adding pagination to workflowRuns in the database queries
  • moving all the filtering and sorting to the db queries
  • adding some commonly used metadata from executionData to workflowRun schema so that we can have reduced network load in the frontend like phase, resiliency score etc.
  • added frontend changes to use the new API.

Contains both frontend and backend changes

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

arkajyotiMukherjee and others added 11 commits May 14, 2021 17:39
@arkajyotiMukherjee
added pagination for QueryWorkflowRuns
0e5b950 
Signed-off-by: arkajyotiMukherjee <arko@chaosnative.com>
@arkajyotiMukherjee
merging pagination branch with master
276ed71 
Signed-off-by: arkajyotiMukherjee <arko@chaosnative.com>
@arkajyotiMukherjee
filtering workflowRuns based on workflowRunIDs
c561a26 
Signed-off-by: arkajyotiMukherjee <arko@chaosnative.com>
@arkajyotiMukherjee
changed the API for getWorkflowRuns in frontend
1a5c963 
Signed-off-by: arkajyotiMukherjee <arko@chaosnative.com>
@arkajyotiMukherjee
added pagination for frontend and refactored code to accomodate the c…
ff57b5f 
…hanges

Signed-off-by: arkajyotiMukherjee <arko@chaosnative.com>
@SarthakJain26
Added Sorting and Filtering
7a50efd 
Signed-off-by: SarthakJain26 <sarthak@chaosnative.com>
@arkajyotiMukherjee
sorting added from backend api call
15f0d1a 
Signed-off-by: arkajyotiMukherjee <arko@chaosnative.com>
@arkajyotiMukherjee
filtering removed from frontend and used backend APIs to filter data
3d72e51 
Signed-off-by: arkajyotiMukherjee <arko@chaosnative.com>
@arkajyotiMukherjee
typed execution data in backend and sent common metadata from executi…
d09ce14 
…on data in workflowruns hence reducing the data size in frontend; sorting based on workflowrun phase done in backend

Signed-off-by: arkajyotiMukherjee <arko@chaosnative.com>
@arkajyotiMukherjee
changing resiliency score to null in case of running workflows
9fcf93a 
Signed-off-by: arkajyotiMukherjee <arko@chaosnative.com>
@arkajyotiMukherjee
Merge branch 'master' of https://github.com/litmuschaos/litmus into p…
9dacdbe 
…agination
@arkajyotiMukherjee arkajyotiMukherjee added this to the 2.0-Beta-7 milestone May 21, 2021
@arkajyotiMukherjee
WIP: filtering and sorting done, pagination remaining
c3ca53e 
Signed-off-by: arkajyotiMukherjee <arko@chaosnative.com>
@arkajyotiMukherjee
pagination completed in database
decd1b5 
Signed-off-by: arkajyotiMukherjee <arko@chaosnative.com>
@arkajyotiMukherjee
reverted ID -> String changes
f693fe0 
Signed-off-by: arkajyotiMukherjee <arko@chaosnative.com>
@arkajyotiMukherjee
Merge branch 'master' of https://github.com/litmuschaos/litmus into p…
556ba78 
…agination

Signed-off-by: arkajyotiMukherjee <arko@chaosnative.com>
@arkajyotiMukherjee arkajyotiMukherjee changed the title Enhancement: Moving pagination, sorting and filtering of workflow runs table to the backend WIP: Enhancement: Moving pagination, sorting and filtering of workflow runs table to the backend May 27, 2021
arkajyotiMukherjee and others added 3 commits May 27, 2021 19:27
@arkajyotiMukherjee
changed the sortStage
92396f0 
Signed-off-by: arkajyotiMukherjee <arko@chaosnative.com>
@SarthakJain26
Added condition to check no workflows
a8c8659 
Signed-off-by: SarthakJain26 <sarthak@chaosnative.com>
@arkajyotiMukherjee
Merge branch 'master' of https://github.com/litmuschaos/litmus into p…
667422e 
…agination
@arkajyotiMukherjee
removed comments from config
6bf768d 
Signed-off-by: arkajyotiMukherjee <arko@chaosnative.com>
@arkajyotiMukherjee arkajyotiMukherjee requested review from SarthakJain26 and removed request for SarthakJain26 June 4, 2021 11:13
ishangupta-ds
ishangupta-ds requested changes Jun 4, 2021
View reviewed changes
Copy link
Member

@ishangupta-ds ishangupta-ds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One translation can be added, gofmt too. Also generated binary can be removed from the server. @arkajyotiMukherjee

@arkajyotiMukherjee
resolved review comments: translations, formatting and removing binar…
79b2e08 
…y file

Signed-off-by: arkajyotiMukherjee <arko@chaosnative.com>
imrajdas
imrajdas requested changes Jun 4, 2021
View reviewed changes
Copy link
Member

@imrajdas imrajdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this bin- litmus-portal/graphql-server/server

litmus-portal/graphql-server/pkg/database/mongodb/workflow/schema.go Outdated Show resolved Hide resolved
@arkajyotiMukherjee
fixed some bugs and added Execution data to types.go
d5e2107 
Signed-off-by: arkajyotiMukherjee <arko@chaosnative.com>
@arkajyotiMukherjee
Copy link
Contributor Author

Addressed all changes. PTAL @rajdas98 @gdsoumya @ishangupta-ds @Jonsy13

ishangupta-ds
ishangupta-ds approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@ishangupta-ds ishangupta-ds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ishangupta-ds
Copy link
Member

@arkajyotiMukherjee please check the import order some checks are failing

@arkajyotiMukherjee
go fmt project
c2c20a0 
Signed-off-by: arkajyotiMukherjee <arko@chaosnative.com>
@arkajyotiMukherjee
Copy link
Contributor Author

done @ishangupta-ds

gdsoumya
gdsoumya approved these changes Jun 5, 2021
View reviewed changes
Copy link
Member

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes pending:

  • optimise the pipeline and filter in one step

@imrajdas imrajdas merged commit aa5fe68 into litmuschaos:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imrajdas imrajdas imrajdas approved these changes

@Jonsy13 Jonsy13 Jonsy13 approved these changes

@gdsoumya gdsoumya gdsoumya approved these changes

@ishangupta-ds ishangupta-ds ishangupta-ds approved these changes

@amityt amityt Awaiting requested review from amityt

@SarthakJain26 SarthakJain26 Awaiting requested review from SarthakJain26

Assignees

@arkajyotiMukherjee arkajyotiMukherjee

@SarthakJain26 SarthakJain26

Labels
area/litmus-portal DO NOT MERGE kind/enhancement PR: Changes Requested READY TO MERGE size/XXL
Projects
None yet
Milestone
2.0-Beta-7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@arkajyotiMukherjee @ishangupta-ds @imrajdas @Jonsy13 @gdsoumya @SarthakJain26