Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improving the env vars management in the graphql-server #3868

Merged
merged 6 commits into from Mar 13, 2023

Conversation

imrajdas
Copy link
Member

Signed-off-by: Raj Babu Das mail.rajdas@gmail.com

Proposed changes

  • os.GetEnv has been used a lot of times in the codebase. Moving all the envs to EnvConfig makes it easy to identify the vars in one place and easily manageable.
  • Move the "cluster/agent" related functions to pkg/cluster.

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

Signed-off-by: Raj Babu Das <mail.rajdas@gmail.com>
Signed-off-by: Raj Babu Das <mail.rajdas@gmail.com>
litmus-portal/graphql-server/utils/variables.go Outdated Show resolved Hide resolved
litmus-portal/graphql-server/pkg/k8s/client.go Outdated Show resolved Hide resolved
litmus-portal/graphql-server/server.go Outdated Show resolved Hide resolved
Signed-off-by: Raj Babu Das <mail.rajdas@gmail.com>
Copy link
Contributor

@Jonsy13 Jonsy13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from 1 comment, rest looks good!

@Jonsy13 Jonsy13 merged commit 6b5202c into litmuschaos:master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants