Better logging for backend components #3939
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,7 @@ import ( | |
| "github.com/litmuschaos/litmus/litmus-portal/graphql-server/graph/model" | ||
| "github.com/litmuschaos/litmus/litmus-portal/graphql-server/pkg/authorization" | ||
| imageRegistryOps "github.com/litmuschaos/litmus/litmus-portal/graphql-server/pkg/image_registry/ops" | ||
| log "github.com/sirupsen/logrus" | ||
| ) | ||
|
|
||
| func (r *mutationResolver) CreateImageRegistry(ctx context.Context, projectID string, imageRegistryInfo model.ImageRegistryInput) (*model.ImageRegistryResponse, error) { | ||
|
|
@@ -22,7 +22,8 @@ func (r *mutationResolver) CreateImageRegistry(ctx context.Context, projectID st | |
|
|
||
| ciResponse, err := imageRegistryOps.CreateImageRegistry(ctx, projectID, imageRegistryInfo) | ||
| if err != nil { | ||
| log.Error(err) | ||
|
There was a problem hiding this comment. Can you convert all if err != nil condition logs to There was a problem hiding this comment. Hey @S-ayanide, There was a problem hiding this comment. Yes that is the expectation, if something in the middle goes wrong we'd want to terminate that function with a Fatal message. @amityt correct me if I'm wrong. There was a problem hiding this comment. No There was a problem hiding this comment. If we use There was a problem hiding this comment. Yes, |
||
| return nil, err | ||
| } | ||
| return ciResponse, err | ||
| } | ||
|
|
@@ -37,7 +38,8 @@ func (r *mutationResolver) UpdateImageRegistry(ctx context.Context, imageRegistr | |
|
|
||
| uiRegistry, err := imageRegistryOps.UpdateImageRegistry(ctx, imageRegistryID, projectID, imageRegistryInfo) | ||
| if err != nil { | ||
| log.Error(err) | ||
namkyu1999 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| return nil, err | ||
| } | ||
|
|
||
| return uiRegistry, err | ||
|
|
@@ -53,7 +55,8 @@ func (r *mutationResolver) DeleteImageRegistry(ctx context.Context, imageRegistr | |
|
|
||
| diRegistry, err := imageRegistryOps.DeleteImageRegistry(ctx, imageRegistryID, projectID) | ||
| if err != nil { | ||
| log.Error(err) | ||
namkyu1999 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| return "", err | ||
| } | ||
|
|
||
| return diRegistry, err | ||
|
|
@@ -69,7 +72,8 @@ func (r *queryResolver) ListImageRegistry(ctx context.Context, projectID string) | |
|
|
||
| imageRegistries, err := imageRegistryOps.ListImageRegistries(ctx, projectID) | ||
| if err != nil { | ||
| log.Error(err) | ||
namkyu1999 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| return nil, err | ||
| } | ||
|
|
||
| return imageRegistries, err | ||
|
|
@@ -85,7 +89,8 @@ func (r *queryResolver) GetImageRegistry(ctx context.Context, imageRegistryID st | |
|
|
||
| imageRegistry, err := imageRegistryOps.GetImageRegistry(ctx, imageRegistryID, projectID) | ||
| if err != nil { | ||
| log.Error(err) | ||
namkyu1999 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| return nil, err | ||
| } | ||
|
|
||
| return imageRegistry, err | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.