Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] move CUSTOM_TLS_CERT to secret #3972

Closed
wants to merge 1 commit into from

Conversation

Akshit42-hue
Copy link

Fixes #3943

Signed-off-by: Akshit42-hue <patelakshit2025@gmail.com>
@Akshit42-hue
Copy link
Author

cc @imrajdas

@neelanjan00
Copy link
Member

I think this will only encode CUSTOM_TLS_CERT value in base64, do we also need to change the logic where it is being consumed?

@gdsoumya
Copy link
Member

Needs subscriber-side changes to read the cert from the secret instead of configmap, and also as @neelanjan00 mentioned if you put the data inside data it needs to be base64 encode so instead put it under stringData

@@ -23,6 +22,8 @@ metadata:
stringData:
CLUSTER_ID: #{CLUSTER_ID}
ACCESS_KEY: #{ACCESS_KEY}
Copy link

@afzal442 afzal442 May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add here instead,
CUSTOM_TLS_CERT: "#{CUSTOM_TLS_CERT}"

Hi Axit, I have already mentioned in the issue. You need to think before you push. Also you have to change the logic as told by @neelanjan00. GD!

Copy link
Author

@Akshit42-hue Akshit42-hue May 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I am working on it.

@Akshit42-hue Akshit42-hue changed the title move CUSTOM_TLS_CERT to secret [WIP] move CUSTOM_TLS_CERT to secret May 17, 2023
@Saranya-jena
Copy link
Contributor

Hi @Akshit42-hue are you still working on it? You would to add changes in chaoscenter directory.

@Saranya-jena
Copy link
Contributor

Closing due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the CUSTOM_TLS_CERT from subscriber config to subscriber secret
5 participants