-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] move CUSTOM_TLS_CERT to secret #3972
Conversation
Signed-off-by: Akshit42-hue <patelakshit2025@gmail.com>
cc @imrajdas |
I think this will only encode |
Needs subscriber-side changes to read the cert from the secret instead of configmap, and also as @neelanjan00 mentioned if you put the data inside |
@@ -23,6 +22,8 @@ metadata: | |||
stringData: | |||
CLUSTER_ID: #{CLUSTER_ID} | |||
ACCESS_KEY: #{ACCESS_KEY} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add here instead,
CUSTOM_TLS_CERT: "#{CUSTOM_TLS_CERT}"
Hi Axit, I have already mentioned in the issue. You need to think before you push. Also you have to change the logic as told by @neelanjan00. GD!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I am working on it.
Hi @Akshit42-hue are you still working on it? You would to add changes in |
Closing due to inactivity |
Fixes #3943