feat: Litmus 3.0: Added enhancements in subscriber for Litmus 3.0 #4027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Kumar Das <amit.das@harness.io>
Signed-off-by: Amit Kumar Das <amit.das@harness.io>
Signed-off-by: Amit Kumar Das <amit.das@harness.io>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| continue | ||
| } | ||
| if r.Payload.Errors != nil { | ||
| logrus.Error("Error response from the server : ", string(message)) |
Check failure
Code scanning / CodeQL
Log entries created from user input High
|
|
||
| // disable ssl verification if configured | ||
| if strings.ToLower(infraData["SKIP_SSL_VERIFY"]) == "true" { | ||
| http.DefaultTransport.(*http.Transport).TLSClientConfig = &tls.Config{InsecureSkipVerify: true} |
Check failure
Code scanning / CodeQL
Disabled TLS certificate check High
| // disable ssl verification if configured | ||
| if strings.ToLower(infraData["SKIP_SSL_VERIFY"]) == "true" { | ||
| http.DefaultTransport.(*http.Transport).TLSClientConfig = &tls.Config{InsecureSkipVerify: true} | ||
| websocket.DefaultDialer.TLSClientConfig = &tls.Config{InsecureSkipVerify: true} |
Check failure
Code scanning / CodeQL
Disabled TLS certificate check High
Jonsy13
reviewed
Jun 29, 2023
|
|
||
| cfg, err := k8s.GetKubeConfig() | ||
| if err != nil { | ||
| logrus.WithError(err).Fatal("could not get config") |
There was a problem hiding this comment.
Suggested change
| logrus.WithError(err).Fatal("could not get config") | |
| logrus.WithError(err).Fatal("could not get kube config") |
Jonsy13
reviewed
Jun 29, 2023
|
|
||
| cfg, err := k8s.GetKubeConfig() | ||
| if err != nil { | ||
| logrus.WithError(err).Fatal("could not get config") |
There was a problem hiding this comment.
Suggested change
| logrus.WithError(err).Fatal("could not get config") | |
| logrus.WithError(err).Fatal("could not get kubeconfig") |
Signed-off-by: Amit Kumar Das <amit.das@harness.io>
Saranya-jena
approved these changes
Jun 29, 2023
|
Looks Good 🚀 |
Jonsy13
approved these changes
Jun 29, 2023
Jonsy13
approved these changes
Jun 29, 2023
SohamRatnaparkhi
pushed a commit
to SohamRatnaparkhi/litmus
that referenced
this pull request
Jun 30, 2023
…tmuschaos#4027) * feat: Litmus 3.0: Added subscriber base setup Signed-off-by: Amit Kumar Das <amit.das@harness.io> * feat: Litmus 3.0: Added events for chaosengine and workflows Signed-off-by: Amit Kumar Das <amit.das@harness.io> * feat: Litmus 3.0: Added logs and minor changes Signed-off-by: Amit Kumar Das <amit.das@harness.io> * updated logs Signed-off-by: Amit Kumar Das <amit.das@harness.io> --------- Signed-off-by: Amit Kumar Das <amit.das@harness.io> Co-authored-by: Saranya Jena <saranya.jena@harness.io>
SohamRatnaparkhi
pushed a commit
to SohamRatnaparkhi/litmus
that referenced
this pull request
Jun 30, 2023
…tmuschaos#4027) * feat: Litmus 3.0: Added subscriber base setup Signed-off-by: Amit Kumar Das <amit.das@harness.io> * feat: Litmus 3.0: Added events for chaosengine and workflows Signed-off-by: Amit Kumar Das <amit.das@harness.io> * feat: Litmus 3.0: Added logs and minor changes Signed-off-by: Amit Kumar Das <amit.das@harness.io> * updated logs Signed-off-by: Amit Kumar Das <amit.das@harness.io> --------- Signed-off-by: Amit Kumar Das <amit.das@harness.io> Co-authored-by: Saranya Jena <saranya.jena@harness.io> Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue
Types of changes
What types of changes does your code introduce to Litmus? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: