Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test/exp run: Handler and service tests for experiment run package #4126

Merged
merged 28 commits into from
Aug 16, 2023
Merged

Test/exp run: Handler and service tests for experiment run package #4126

merged 28 commits into from
Aug 16, 2023

Conversation

SohamRatnaparkhi
Copy link
Contributor

@SohamRatnaparkhi SohamRatnaparkhi commented Aug 15, 2023 •
edited
Loading

This PR adds tests for the experiment run package created in #4053

Proposed changes

Tests for handlers and services have been added.

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

These PR is dependent on #4053

Special notes for your reviewer:

The changes made in this PR are related to LFX Mentorship-Term2

@SohamRatnaparkhi
feat: seperate exp_run and exp grapql schemas
2f4b1f9 
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
@SohamRatnaparkhi
feat: seperate exp_run and exp graphql resolvers
bde72b7 
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
@SohamRatnaparkhi
feat: add generated types
2f05776 
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
@SohamRatnaparkhi
feat: add types for exp_run
ab4e653 
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
@SohamRatnaparkhi
feat: add exp_run services
6c049f3 
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
@SohamRatnaparkhi
feat: add exp_run handler
0113576 
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
@SohamRatnaparkhi
refractor: remove functions in experiments service related to runs
7169510 
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
@SohamRatnaparkhi
refractor: remove functions in experiments handler related to runs
e386415 
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
@SohamRatnaparkhi
fix: issues due to handler and resolver types
3b977f6 
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
@SohamRatnaparkhi
Merge branch 'master' of https://github.com/SohamRatnaparkhi/litmus i…
9712c2c 
…nto feature/chaos-run
@SohamRatnaparkhi
fix: breaking changes in generated and service files
9fc82fb 
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
@SohamRatnaparkhi
fix: bugs in experiment handlers and roles
5cfb390 
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
@SohamRatnaparkhi
fix: add exp run operator and update handler
28d5920 
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
@SohamRatnaparkhi
fix: update infra opr to return exp-run
f70b80c 
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
@SohamRatnaparkhi
feat: add gitops mocks
3f8a46d 
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
@SohamRatnaparkhi
feat: add mongo operations
6c743a9 
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
@SohamRatnaparkhi
refractor: schemas for new types
13d45e8 
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
@SohamRatnaparkhi
feat: mocks service for exp-run
3b38355 
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
@SohamRatnaparkhi
feat: handler tests for exp-run
567272d 
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
@SohamRatnaparkhi
fix: package update to match latest changes
9f252d6 
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
@SohamRatnaparkhi
feat: test for exp-run service
f85c0bb 
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
@SohamRatnaparkhi
feat: infra service mocks
22534db 
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
@SohamRatnaparkhi
feat: test for exp handlers(incomplete)
52cffa1 
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
@SohamRatnaparkhi
fix: local mongo opr usage instead of global
cca2ff8 
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
@SohamRatnaparkhi
feat: incomplete GetExpRun and ReRunExp tests
d31d60d 
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
@SohamRatnaparkhi
feat: complete services tests
72ae50f 
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
@SohamRatnaparkhi
feat: complete handler tests
83dd7d8 
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
@SohamRatnaparkhi SohamRatnaparkhi mentioned this pull request Aug 15, 2023
Merged
9 tasks
@SohamRatnaparkhi SohamRatnaparkhi changed the title Test/exp run Test/exp run: Handler and service tests for experiment run package Aug 15, 2023
@Saranya-jena Saranya-jena merged commit fcc8382 into litmuschaos:master Aug 16, 2023
14 checks passed
amityt added a commit that referenced this pull request Aug 16, 2023
@amityt
Revert "Test/exp run: Handler and service tests for experiment run pa…
63bf007 
…ckage (#4126)"

This reverts commit fcc8382.
@Saranya-jena Saranya-jena mentioned this pull request Aug 16, 2023
Merged
Saranya-jena added a commit that referenced this pull request Aug 16, 2023
@Saranya-jena @amityt
Revert "Test/exp run: Handler and service tests for experiment run pa…
edb61a1 
…ckage (#4126)" (#4129)

This reverts commit fcc8382.

Co-authored-by: Amit Kumar Das <amit.das@harness.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saranya-jena Saranya-jena Awaiting requested review from Saranya-jena

@arkajyotiMukherjee arkajyotiMukherjee Awaiting requested review from arkajyotiMukherjee

@amityt amityt Awaiting requested review from amityt

Assignees

@SohamRatnaparkhi SohamRatnaparkhi

Labels
kind/unit-test language/go LFX-MENTORSHIP Linux Foundation Mentor ship Issue READY-FOR-REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SohamRatnaparkhi @Saranya-jena @namkyu1999