Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isRegistered check in GetK8sInfraYaml(ChaosCenter/graphql) #4127

Merged
merged 2 commits into from Oct 4, 2023

Conversation

Nageshbansal
Copy link
Contributor

@Nageshbansal Nageshbansal commented Aug 15, 2023

Proposed changes

Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

Because of the "isRegistered" check, the GetK8sInfraYaml function couldn't give us the Infra Manifest as it should. Instead, it gave us the Manifest with the message "Infra is Already Registered." To fix this and make the getInfraManifest gql API work properly, we had to remove the check. This also meant we had to change how ChaosCenter Frontend Handles the update command.

@Nageshbansal Nageshbansal changed the title Fix isRegistered check in GetK8sInfraYaml Fix isRegistered check in GetK8sInfraYaml(ChaosCenter/graphql) Aug 15, 2023
@Nageshbansal Nageshbansal marked this pull request as ready for review August 24, 2023 11:51
@Nageshbansal Nageshbansal force-pushed the fix_getManifest branch 2 times, most recently from 65ff99c to 7003259 Compare August 24, 2023 13:46
Signed-off-by: nagesh bansal <nageshbansal59@gmail.com>
@Nageshbansal
Copy link
Contributor Author

@Saranya-jena any updates on this?

@Saranya-jena Saranya-jena merged commit 835a670 into litmuschaos:master Oct 4, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants