Test/chaos experiments: Tests for handlers and services

[SohamRatnaparkhi]

Proposed changes

Closes #4050
This PR consists tests for handlers and services in choas_experiment package

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

• New feature (non-breaking change which adds functionality)
• Bugfix (non-breaking change which fixes an issue)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• I have read the CONTRIBUTING doc
• I have signed the commit for DCO to be passed.
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works (if appropriate)
• I have added necessary documentation (if appropriate)

Dependency

• This PR depends on Pr Test/mocks: added mocks for test cases #4133

Special notes for your reviewer:

This PR is related to LFX Mentorship-Term2

[namkyu1999]

Hello @SohamRatnaparkhi, Can you rename choas to chaos and check that all the test cases work, please?

[SohamRatnaparkhi]

Hello @SohamRatnaparkhi, Can you rename choas to chaos and check that all the test cases work, please?

Hey @namkyu1999
Just noticed that there are 2 packages named chaos_experiment_runs and choas_experiment_runs.
But, the chaos_experiment_runs, doesn't have the model/mocks and test files.

So, in this PR itself, should I add them to the chaos_experiment_runs folder?

There are failing testcases, but the reason they are failing is because the chaos_experiment_runs package doesn't have any mocks.

[namkyu1999]

Hello @SohamRatnaparkhi, Can you rename choas to chaos and check that all the test cases work, please?

Hey @namkyu1999 Just noticed that there are 2 packages named chaos_experiment_runs and choas_experiment_runs. But, the chaos_experiment_runs, doesn't have the model/mocks and test files.

So, in this PR itself, should I add them to the chaos_experiment_runs folder?

There are failing testcases, but the reason they are failing is because the chaos_experiment_runs package doesn't have any mocks.

Hey @SohamRatnaparkhi ,
What's different between chaos_experiment_runs and choas_experiment_runs?
IMO, It would be better if you move all the files in choas_experiment_runs to chaos_experiment_runs

[SohamRatnaparkhi]

Okay cool!
So I will do it in this PR itself.
Right?

[namkyu1999]

Okay cool! So I will do it in this PR itself. Right?

Right 😊

[SohamRatnaparkhi]

Okay cool! So I will do it in this PR itself. Right?

Right 😊

Hey @namkyu1999
I have made the respective changes.
I fell, we can add the service test files and stuff in a separate PR as those changes are not pretty much not linked with the changes in this PR. This PR just required the mocks and I added those in this PR.

In a separate PR, we can do 2 things

• add service test files from choas_exp_runs to chaos
• delete the old directory

What's your opinion on this?

[namkyu1999]

Hi @SohamRatnaparkhi ,

Since there aren't many changes in the current PR, and no one has started a review, it would be a good idea to include all the changes in this PR. This is just my opinion, feel free to make your own choices.

[SohamRatnaparkhi]

Hi @SohamRatnaparkhi ,

Since there aren't many changes in the current PR, and no one has started a review, it would be a good idea to include all the changes in this PR. This is just my opinion, feel free to make your own choices.

Hey @namkyu1999
Sorry for being this late :)
Done with the required changes.

[namkyu1999]

This testcase is failed because new operations added since last commit.

UpdateChaosExperiment use this function below

litmus/chaoscenter/graphql/server/pkg/chaos_experiment/handler/handler.go

Lines 248 to 251 in 794676f

	experimentCount, err := c.chaosExperimentOperator.CountChaosExperiments(ctx, filterQuery)
	if err != nil {
	return nil, err
	}

and this operator use a global variable

litmus/chaoscenter/graphql/server/pkg/database/mongodb/chaos_experiment/operations.go

Line 130 in 794676f

res, err := mongodb.Operator.CountDocuments(ctx, mongodb.ChaosExperimentCollection, query)

Can you change this one to local variable and update testcase?

Other than that, LGTM 🚀

[SohamRatnaparkhi]

Made the changes in latest commit!