Added UI screens for Resiliency probes #4154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
…robes-frontend Signed-off-by: Saranya-jena <saranya.jena@harness.io>
S-ayanide
requested changes
Sep 6, 2023
| >): GqlAPIQueryResponse<GetExperimentRunResponse, GetExperimentRunRequest> { | ||
| const { data, loading, ...rest } = useQuery<GetExperimentRunResponse, GetExperimentRunRequest>( | ||
| gql` | ||
| query getExperimentRun($identifiers: IdentifiersRequest!, $experimentRunID: String, $notifyID: String) { |
There was a problem hiding this comment.
We are taking projectID but not replacing identifiers with the same
| name | ||
| type | ||
| infrastructureType | ||
| kubernetesHTTPProperties { |
There was a problem hiding this comment.
Please add attempt and evaluationTimeout for all probes, only CMD probe has attempt in this implementation
| username | ||
| } | ||
| httpProperties { |
There was a problem hiding this comment.
Please change this to kubernetesHTTPProperties
| labelSelector | ||
| operation | ||
| } | ||
| cmdProperties { |
There was a problem hiding this comment.
Please change this to kubernetesCMDProperties
| margin={{ right: 'xsmall' }} | ||
| /> | ||
| <Text font={{ variation: FontVariation.H6 }} color={Color.WHITE}> | ||
| NOT STARTED |
S-ayanide
requested changes
Sep 6, 2023
| </Text> | ||
| <Layout.Vertical spacing={'small'}> | ||
| <Text font={{ variation: FontVariation.FORM_LABEL }} color={Color.WHITE}> | ||
| {getString('selectChaosInfrastructureType')} |
There was a problem hiding this comment.
Please comment this string too
| } | ||
| } | ||
|
|
||
| export function getIcon(type: ProbeType): IconName { |
There was a problem hiding this comment.
Can we add the icons for K8S and PROM too if they are published in harnessio!
There was a problem hiding this comment.
Will need more discussion on adding it to OSS, this is for immediate solution.
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
hrishavjha
approved these changes
Sep 6, 2023
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue
Types of changes
What types of changes does your code introduce to Litmus? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: