Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added some text occurrences in UI #4186

Merged
merged 20 commits into from
Oct 27, 2023
Merged

Added some text occurrences in UI #4186

merged 20 commits into from
Oct 27, 2023

Conversation

nanu1605
Copy link
Contributor

Added some text occurrences in UI which are not added to strings.en.yaml for translation and replaced the occurrences with getString(' ') in chaoscenter/web. #4147

@nanu1605
Copy link
Contributor Author

Hello @Saranya-jena, please take a look at the changes.

@namkyu1999
Copy link
Member

Check DCO, please

Saranya-jena and others added 9 commits September 25, 2023 23:17
@Saranya-jena @nanu1605
Fixed issue with updating audit fields in recent experiment runs (#4172)
243e123 
* fixed mongo schema decode issue

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* updated the same in other fields

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* fixed css

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

---------

Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Tanishq Jain <tanishqjain010@gmail.com>
@hrishavjha @nanu1605
fix: Fixed teaming page UI Issues (#4173)
7228b5e 
Signed-off-by: Hrishav <hrishav.kumar@harness.io>
Signed-off-by: Tanishq Jain <tanishqjain010@gmail.com>
@hrishavjha @nanu1605
fix: Updated config to support favicon (#4179)
f4eec0d 
Signed-off-by: Hrishav <hrishav.kumar@harness.io>
Signed-off-by: Tanishq Jain <tanishqjain010@gmail.com>
@nanu1605
replace string with corresponding keys
52eef8f 
Signed-off-by: Tanishq Jain <tanishqjain010@gmail.com>
@nanu1605
replace string with corresponding keys
5c9b5b5 
Signed-off-by: Tanishq Jain <tanishqjain010@gmail.com>
@nanu1605
replaced the text string with the corresponding keys Signed-off-by:
c6f18ec 
Tanishq Jain <tanishqjain010@gmail.com>

Signed-off-by: Tanishq Jain <tanishqjain010@gmail.com>
@amityt @nanu1605
fix: Added experiment run operator for NewChaosExperimentService (#4184)
c6bbacb 
Signed-off-by: Amit Kumar Das <amit.das@harness.io>
Signed-off-by: Tanishq Jain <tanishqjain010@gmail.com>
@nanu1605
Merge branch 'master' into master
1b5d969
@nanu1605
Merge branch 'litmuschaos:master' into master
0f9b470
@nanu1605
Copy link
Contributor Author

@namkyu1999 Please take a look at this PR

namkyu1999
namkyu1999 requested changes Sep 27, 2023
View reviewed changes
Copy link
Member

@namkyu1999 namkyu1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
I requested few changes

  1. Can you resolve all the issues I mentioned?
  2. Can you also make all these changes to web/src/strings/types.ts
  3. After changes, Can you sort and check strings via yarn strings:sort and yarn strings:check ?

chaoscenter/web/src/components/InputSlider/InputSlider.tsx Outdated Show resolved Hide resolved
chaoscenter/web/src/strings/strings.en.yaml Outdated Show resolved Hide resolved
chaoscenter/web/src/views/AddHubModalWizard/AddHubModalWizard.tsx Outdated Show resolved Hide resolved
chaoscenter/web/src/strings/strings.en.yaml Outdated Show resolved Hide resolved
chaoscenter/web/src/views/AddProbeModalWizard/AddProbeModalWizard.tsx Outdated Show resolved Hide resolved
chaoscenter/web/src/views/AddProbeModalWizard/AddProbeModalWizard.tsx Outdated Show resolved Hide resolved
chaoscenter/web/src/strings/strings.en.yaml Outdated Show resolved Hide resolved
chaoscenter/web/src/strings/strings.en.yaml Outdated Show resolved Hide resolved
chaoscenter/web/src/views/AddProbeModalWizard/AddProbeModalWizard.tsx Outdated Show resolved Hide resolved
chaoscenter/web/src/views/AddProbeModalWizard/AddProbeModalWizard.tsx Outdated Show resolved Hide resolved
@nanu1605 @namkyu1999
Apply suggestions from code review
fbcf9d4 
Co-authored-by: Namkyu Park <53862866+namkyu1999@users.noreply.github.com>
Signed-off-by: Tanishq Jain <tanishqjain010@gmail.com>
@nanu1605
Copy link
Contributor Author

Will update the web/src/strings/types.ts ASAP

@nanu1605
Copy link
Contributor Author

nanu1605 commented Sep 28, 2023 •
edited
Loading

@namkyu1999 To regenerate type.ts should I go to folder /chaoscenter/web and run yarn strings?

@namkyu1999
Copy link
Member

@namkyu1999 To regenerate type.ts should I go to folder /chaoscenter/web and run yarn strings?

Hey @nanu1605 , go to the /chaoscenter/web and
yarn strings:check => check whether your strings are duplicated or not
yarn strings:sort => sort strings
yarn build => this is what you want

I recommend you doing all of them :)

@nanu1605
updated type.ts using yarn strings
8bda0ec 
Signed-off-by: Tanishq Jain <tanishqjain010@gmail.com>
@nanu1605
Merge branch 'master' into master
3544876 
Signed-off-by: Tanishq Jain <tanishqjain010@gmail.com>
@nanu1605
Copy link
Contributor Author

@namkyu1999 Please take a look at this PR :)

namkyu1999
namkyu1999 approved these changes Sep 30, 2023
View reviewed changes
Copy link
Member

@namkyu1999 namkyu1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀🚀

@Saranya-jena
Merge branch 'master' into master
3fba05c 
Signed-off-by: Saranya Jena <saranya.jena@harness.io>
@Saranya-jena Saranya-jena merged commit 4bdeea3 into litmuschaos:master Oct 27, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saranya-jena Saranya-jena Saranya-jena approved these changes

@amityt amityt amityt approved these changes

@namkyu1999 namkyu1999 namkyu1999 approved these changes

@SahilKr24 SahilKr24 SahilKr24 approved these changes

@arkajyotiMukherjee arkajyotiMukherjee Awaiting requested review from arkajyotiMukherjee

Assignees

@nanu1605 nanu1605

Labels
area/chaoscenter good first issue READY-FOR-REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nanu1605 @namkyu1999 @Saranya-jena @amityt @SahilKr24 @hrishavjha