Feat: Tests cases for Chaoscenter Rest handler in Chaoscenter #4238
Conversation
Signed-off-by: freedisch <freeproduc@gmail.com>
namkyu1999
added
LFX-MENTORSHIP
Saranya-jena
requested review from
SarthakJain26,
Jonsy13,
amityt and
namkyu1999
|
Can you resolve conflicts? |
Signed-off-by: Magnim BATALE <82499435+Freedisch@users.noreply.github.com>
Done |
|
|
Signed-off-by: freedisch <freeproduc@gmail.com>
|
@namkyu1999, I just fixed the falling tests |
There was a problem hiding this comment.
LGTM 🚀 @Freedisch, Can you add more test cases in each unit test? In most unit tests, there is only one test case. Checking code coverage will help you figure out which cases you need to add.
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestDexLogin(t *testing.T) { |
There was a problem hiding this comment.
Can you also add positive case?
chaoscenter/authentication/api/handlers/rest/project_handler_test.go
Outdated
Show resolved
Hide resolved
chaoscenter/authentication/api/handlers/rest/project_handler_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Thank you for inproving the test suite.
Also please address the review comments left by @namkyu1999
Sure I'm working on it |
Signed-off-by: freedisch <freeproduc@gmail.com>
There was a problem hiding this comment.
Can you check failed cases? I will approve this pr when you fix it 🚀 @Freedisch
Signed-off-by: freedisch <freeproduc@gmail.com>
|
@namkyu1999, I just finished fixing the falling test and added a few ones |
Proposed changes
This PR add test cases for Chaoscenter authentication Rest handler
Types of changes
What types of changes does your code introduce to Litmus? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: