Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactos: GraphQL Server to Remove unused RBAC's #4265

Merged
merged 11 commits into from Mar 6, 2024

Conversation

RipulHandoo
Copy link
Contributor

@RipulHandoo RipulHandoo commented Nov 7, 2023

Proposed changes

Removed deprecated and unused RBACs:

  • Checked for the Deprecated/Unused RBAC in roles.go.
  • Deleted RBAC definition for SyncHub

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

This PR solve issue #4120, by removing the unused RBAC's

Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@SohamRatnaparkhi
Copy link
Contributor

LGTM 🚀

@Saranya-jena Saranya-jena requested review from Saranya-jena and namkyu1999 and removed request for Saranya-jena November 10, 2023 06:54
@namkyu1999
Copy link
Member

Hey @RipulHandoo , Can you check build-pipeline / docker-build-graphql-server (pull_request) ?

Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@Saranya-jena Saranya-jena changed the title Refactos: GraphQL Server to Remove unused RABC's Refactos: GraphQL Server to Remove unused RBAC's Nov 15, 2023
@RipulHandoo
Copy link
Contributor Author

Hey @RipulHandoo , Can you check build-pipeline / docker-build-graphql-server (pull_request) ?

@namkyu1999 PTAL!

Copy link
Member

@namkyu1999 namkyu1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check my comments, please!

Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@Saranya-jena Saranya-jena merged commit 5778044 into litmuschaos:master Mar 6, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants