Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update subscriber to use Kubernetes patch for ConfigMaps an… #4287

Merged
merged 6 commits into from
Feb 12, 2024

Conversation

RipulHandoo
Copy link
Contributor

…d Secrets instead of get-update

Proposed changes

In the ClusterRegister function within operations.go, I've replaced the 'update' method with 'kubernetes patch' for updating ConfigMaps and Secrets. This change involves using 'json.Marshal' to serialize the clusterData, which is then utilized in 'Patch' with 'MergePatchType' for both ConfigMap and Secret updates.

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

This PR solve's this #3944

…d Secrets instead of get-update

Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@Saranya-jena Saranya-jena requested review from imrajdas, gdsoumya and amityt and removed request for imrajdas and gdsoumya November 10, 2023 06:51
Copy link
Contributor

@Saranya-jena Saranya-jena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @RipulHandoo you would need to add the changes in chaoscenter directory since with the release of Litmus 3.0, litmus-portal dir has been deprecated.

@RipulHandoo
Copy link
Contributor Author

Hey @RipulHandoo you would need to add the changes in chaoscenter directory since with the release of Litmus 3.0, litmus-portal dir has been deprecated.

Sure, I'll make the necessary changes in this file shortly.

Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@RipulHandoo
Copy link
Contributor Author

Hey @RipulHandoo you would need to add the changes in chaoscenter directory since with the release of Litmus 3.0, litmus-portal dir has been deprecated.

Hey @Saranya-jena, I have made necessary changes in the chaoscenter . Please review and let me know if everything is okay.

chaoscenter/subscriber/pkg/k8s/operations.go Outdated Show resolved Hide resolved
chaoscenter/subscriber/pkg/k8s/operations.go Outdated Show resolved Hide resolved
Signed-off-by: Ripul Handoo <107461226+RipulHandoo@users.noreply.github.com>
@Saranya-jena Saranya-jena merged commit d23414e into litmuschaos:master Feb 12, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants