Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile of litmus-portal frontend for OpenShift #4396

Conversation

Calvinaud
Copy link
Contributor

Proposed changes

Update litmus-portal frontend Dockerfile to be more Openshift friendly.

  • Update the chown command so that the GID of the folders/files is at 0 since Openshift will by default use a random UID but is part of the root group.
  • Combine the 3 RUN for chown command into a single one to reduce number of layers

Link to the issues:

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • [NA] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Special notes for your reviewer:

I combined the 3 RUN line into a single one to reduce number of layers. If you don't like it I can reverse this change.

- Update the chown command for openshift need
- Combine the 3 RUN for chown command into a single one to reduce number of layers

Signed-off-by: Calvin Audier <calvin.audier@gmail.com>
Copy link
Contributor

@Saranya-jena Saranya-jena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🚀

@Saranya-jena Saranya-jena merged commit 3459e7e into litmuschaos:master Mar 15, 2024
18 checks passed
kartikaysaxena pushed a commit to kartikaysaxena/litmus that referenced this pull request Apr 6, 2024
- Update the chown command for openshift need
- Combine the 3 RUN for chown command into a single one to reduce number of layers

Signed-off-by: Calvin Audier <calvin.audier@gmail.com>
Co-authored-by: Calvin Audier <calvin.audier@gmail.com>
Co-authored-by: Saranya Jena <saranya.jena@harness.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants