New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [CHAOS-3808]: Resilience probe modal toggle reseting to default bugfix #4431
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
search: `probeName=${rowDetails.name}&tab=${ProbeTabs.EXECUTION_RESULTS}&infrastructureType=${rowDetails.infrastructureType}` | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
search: `probeName=${rowDetails.name}&tab=${ProbeTabs.EXECUTION_RESULTS}&infrastructureType=${rowDetails.infrastructureType}` | |
}) | |
search: new URLSearchParams({ | |
probeName: rowDetails.name, | |
tab: ProbeTabs.EXECUTION_RESULTS, | |
infrastructureType: rowDetails.infrastructureType | |
}) |
this will urlify the params and escape issue causing characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a type mismatch Type 'URLSearchParams' is not assignable to type 'string | { (regexp: string | RegExp): number; (searcher: { [Symbol.search](string: string): number; }): number; } | undefined'
Even if you scope it above and set it using a const, the type of URLSearchParams isn't compatible with search param
chaoscenter/web/src/views/ExperimentCreationFaultConfiguration/Tabs/Probes/MenuCell.tsx
Outdated
Show resolved
Hide resolved
chaoscenter/web/src/views/ExperimentCreationFaultConfiguration/Tabs/Probes/Probes.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes
Proposed changes
Resilience probe modal toggle is reseting to original value on clicking back, this change fixes the issue
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: