Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [CHAOS-3808]: Resilience probe modal toggle reseting to default bugfix #4431

Merged
merged 4 commits into from Feb 13, 2024

Conversation

S-ayanide
Copy link
Member

Proposed changes

Resilience probe modal toggle is reseting to original value on clicking back, this change fixes the issue

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

@S-ayanide S-ayanide added the area/resilience-probes Related to Resilience Probes label Feb 12, 2024
Copy link
Member

@hrishavjha hrishavjha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Comment on lines +147 to +148
search: `probeName=${rowDetails.name}&tab=${ProbeTabs.EXECUTION_RESULTS}&infrastructureType=${rowDetails.infrastructureType}`
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
search: `probeName=${rowDetails.name}&tab=${ProbeTabs.EXECUTION_RESULTS}&infrastructureType=${rowDetails.infrastructureType}`
})
search: new URLSearchParams({
probeName: rowDetails.name,
tab: ProbeTabs.EXECUTION_RESULTS,
infrastructureType: rowDetails.infrastructureType
})

this will urlify the params and escape issue causing characters

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a type mismatch Type 'URLSearchParams' is not assignable to type 'string | { (regexp: string | RegExp): number; (searcher: { [Symbol.search](string: string): number; }): number; } | undefined'

Even if you scope it above and set it using a const, the type of URLSearchParams isn't compatible with search param

Copy link
Member

@SahilKr24 SahilKr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes

@S-ayanide S-ayanide merged commit 78d6dec into litmuschaos:master Feb 13, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/resilience-probes Related to Resilience Probes front-end-issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants