Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Litmusctl should check existence of workflow name before scheduling & add the same if not present already #116

Closed
Jonsy13 opened this issue Dec 9, 2022 · 1 comment

Comments

@Jonsy13
Copy link
Collaborator

Jonsy13 commented Dec 9, 2022

If the manifest provided by users doesn't contain name & only contains generateName, It fails with empty workflow name.

Issue :

Currently, Litmusctl expects the users to use workflow.metadata.name explicitly.

Reason :

Graphql-server also checks the workflow name provided via API parameters with workflow.metadata.name before scheduling so that we are able to track the workflow after scheduling. In UI also, we generate the workflow name ourself if workflow doesn't have it.

How we can enhance this?

Litmusctl can check if workflow contains workflow.metadata.name or not. If workflow contains workflow.metadata.generateName & not the workflow.metadata.name, Litmusctl can add the workflow.metadata.name by generating it by adding some hash to generateName . So, workflow.metadata.name will be workflow.metadata.generateName+(some-hash) .

@Jonsy13
Copy link
Collaborator Author

Jonsy13 commented Dec 21, 2022

Thanks @iamnicoj for this contribution!!. This is now released as part of 0.16.0 release of LitmusCTL.

@Jonsy13 Jonsy13 closed this as completed Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant