Litmusctl checks existence of workflow name before scheduling & add the same if not present already #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamnicoj
requested review from
Jonsy13,
Saranya-jena and
SarthakJain26
as code owners
iamnicoj
changed the title
Signed-off-by: Nico J <nicolasj@microsoft.com>
Signed-off-by: Nico J <nicolasj@microsoft.com>
…the json manifest Signed-off-by: Nico J <nicolasj@microsoft.com>
SarthakJain26
approved these changes
Dec 15, 2022
Saranya-jena
approved these changes
Dec 15, 2022
Jonsy13
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #116. It verifies if manifests has the
nameor thegenerateNameattribute to assigned it to the create-scenariochaosWorkflowRequestaccordingly.In case the manifest has the
generateNameattribute it would create a random alphanumeric postfix string and concatenate it to thename. It will also delete thegenerateNameattribute from the manifest before submitting it to the API.