-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(agents): Add delete agent command and refactor other agent commands #73
Merged
imrajdas
merged 6 commits into
litmuschaos:master
from
PrayagS:feat-delete-agent-command
May 25, 2022
Merged
feat(agents): Add delete agent command and refactor other agent commands #73
imrajdas
merged 6 commits into
litmuschaos:master
from
PrayagS:feat-delete-agent-command
May 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrayagS
requested review from
imrajdas,
Jonsy13,
Saranya-jena and
SarthakJain26
as code owners
May 21, 2022 12:46
Hi @PrayagS Can you add screenshots of the command running on the terminal? |
reference -- litmuschaos/litmus#3604 |
PrayagS
force-pushed
the
feat-delete-agent-command
branch
4 times, most recently
from
May 23, 2022 07:02
e090e79
to
1cacc81
Compare
@Saranya-jena Pushed the final changes. Please find the screenshot below, |
PrayagS
changed the title
feat(agents): Add delete agent command
feat(agents): Add delete agent command and refactor other agent commands
May 24, 2022
imrajdas
approved these changes
May 24, 2022
@PrayagS Can you resolve the merge conflicts |
Saranya-jena
approved these changes
May 24, 2022
Signed-off-by: PrayagS <prayagsavsani@gmail.com>
Signed-off-by: PrayagS <prayagsavsani@gmail.com>
Signed-off-by: PrayagS <prayagsavsani@gmail.com>
Signed-off-by: PrayagS <prayagsavsani@gmail.com>
Signed-off-by: PrayagS <prayagsavsani@gmail.com>
Signed-off-by: PrayagS <prayagsavsani@gmail.com>
PrayagS
force-pushed
the
feat-delete-agent-command
branch
from
May 24, 2022 12:04
55486ca
to
0cd52ba
Compare
SarthakJain26
approved these changes
May 24, 2022
Jonsy13
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following changes,
isRegistered
in the output ofget agents
command.create agent
command toconnect agent
for consistency.Signed-off-by: PrayagS prayagsavsani@gmail.com