Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor tabs still holding on to database #37

Closed
jungle-boogie opened this issue May 26, 2021 · 3 comments
Closed

Editor tabs still holding on to database #37

jungle-boogie opened this issue May 26, 2021 · 3 comments

Comments

@jungle-boogie
Copy link

Hi,

Similar to #18

Something in sqlite-gui is still holding on to the database after it's closed in the app. As a result, I can't delete or rename my database file. I haven't yet tracked down what's causing this.

@jungle-boogie
Copy link
Author

I think the editor tabs are keeping the database in use.

  1. Open sqlite-gui
  2. Open database
  3. Run query in new editor tab
  4. Close editor tab
  5. Close database but keep sqlite-gui open
  6. Rename database file

Notice Windows says the file is in use.

I would expect sqlite-gui to always release the database once the application closes the file.

@jungle-boogie jungle-boogie changed the title Something still holding on to database Editor tabs still holding on to database May 26, 2021
@little-brother
Copy link
Owner

Thanks. I forgot to close a connection on a tab closing.

little-brother added a commit that referenced this issue May 30, 2021
* Add histogram and areas to charts
* Improve history/saved queries lists (issue #44)
* Fix issues: #37, #38, #41, #42, #43, #45
@little-brother
Copy link
Owner

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants