-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SS_ADMINER_PUBLIC="false" does not work as intended. #196
Comments
Related: #73 |
Perhaps this is another feature that could be moved to our new Nginx includes approach, like:
|
If we end up doing something like: https://wordpress.org/plugins/db-access-adminer/ Where it requires WP Admin authentication, the entire issue might be moot. |
These patches (above) are temporary, because they delete the |
New sub-module in progress: https://github.com/littlebizzy/slickstack/blob/master/modules/nginx/includes/adminer-conf.txt |
We could probably also hide the Database tab in the SlickStack WP Admin Dashboard if this is set to false, that's something that a few developers had asked about. |
Update: this option in ss-config is now called |
Okay, Adminer is now officially a submodule for Nginx for SlickStack purposes... if New script: I've also removed the temporary fix in ss-clean-files which deleted Notes: We could make this even stronger by adding a 403 denied or something to the Adminer URL, however, now that the URL is a randomized string it's probably not a concern. |
Issue
On version APR2023K, SS_ADMINER_PUBLIC set to "false" still exposes Adminer to the public web.
The text was updated successfully, but these errors were encountered: