Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in ss-install and ss-check dos2unix file permissions #46

Closed
Bronislawsky opened this issue Jun 6, 2020 · 1 comment
Closed

Typo in ss-install and ss-check dos2unix file permissions #46

Bronislawsky opened this issue Jun 6, 2020 · 1 comment

Comments

@Bronislawsky
Copy link

Hello!
ss-install:218:mkdir touch /var/www/meta/.ssh
mkdir should not be there I beleive
and ufw allow @SSH_PORT should be ufw allow $SSH_PORT
no big beal also because users.rules override this

Also
in ss-check dos2unix change de permission of ss and cron files
I dont think its a big deal, but ss-perms and ss-check fight for their permissions :)

@jessuppi
Copy link
Member

jessuppi commented Jun 7, 2020

Thanks @Bronislawsky

ss-install is still pretty messy, I've saved it for last as far as optimization goes. Those typos that you mention have been fixed in the below commit:

Ref: 3aa1aa0

The perms conflicts have also been fixed in these 2 commits:

Ref: 0bb62b8
Ref: 4a57e4c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants