Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Enabled erase=noop in test_rbyd, changed read* to error on leb128 ove…
…rflow Now that reproducibility issues with erase_value=-1 (erase=noop) are fixed, this much more useful to test than erase_value=0x1b. Especially since erase=noop is filled with so many sharp corners. These tests already found that we were being too confident with our leb128/lleb128/tag parsing. Since we need to partially parse unfinished/ old commits, lfsr_dir_read* can easily encounter invalid leb128s during normal operation. If this happens we should not assert. Doing things correctly has a bit of a cost: code stack before: 33928 2840 after: 33976 (+0.1%) 2840 (+0.0%) At least we haven't seen any issues with our valid bit invalidating logic yet.
- Loading branch information