Fix issue where seeking to end-of-directory return LFS_ERR_INVAL #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was just an oversight. Seeking to the end of the directory should not error, but instead restore the directory to the state where the next read returns 0. Note this matches the behavior of lfs_file_tell/lfs_file_seek. Found by sosthene-nitrokey
This was referenced Apr 18, 2023
|
I can't speak for the fix itself but the tests appear to cover the case I describe in #785 and expect the same behaviour I would. |
Merged
yamt
added a commit
to yamt/toywasm
that referenced
this pull request
Apr 30, 2024
seek to the eod is broken in old littlefs. littlefs-project/littlefs#805
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was just an oversight. Seeking to the end of the directory should not error, but instead restore the directory to the state where the next read returns 0.
Note this matches the behavior of lfs_file_tell/lfs_file_seek.
Found by @sosthene-nitrokey, see #785 for more info.