Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't assert on attempting to write a file opened RO #831

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't assert on attempting to write a file opened RO #831

wants to merge 1 commit into from

Commits on May 16, 2023

  1. Don't assert on attempting to write a file opened RO 

    When lfs_file_write() is called on a file opened as read-only, it soon encounters an assertion in lfs_file_rawwrite() that is unhappy with this state. Instead of aborting, return an error and allow the client to handle it properly. This matches the behavior of write(2), which sets errno to EBADF in this case.
    @shacron
    shacron committed May 16, 2023
    Configuration menu
    Copy the full SHA
    f9250ca View commit details
    Browse the repository at this point in the history