Add inline_max, to optionally limit the size of inlined files #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geky
added
enhancement
performance
needs minor version
Tests passed ✓, Code: 16812 B (-0.0%), Stack: 1448 B (+0.0%), Structs: 808 B (+1.0%)
|
geky
added
next minor
and removed
needs minor version
Inlined files live in metadata and decrease storage requirements, but may be limited to improve metadata-related performance. This is especially important given the current plague of metadata performance. Though decreasing inline_max may make metadata more dense and increase block usage, so it's important to benchmark if optimizing for speed. The underlying limits of inlined files haven't changed: 1. Inlined files need to fit in RAM, so <= cache_size 2. Inlined files need to fit in a single attr, so <= attr_max 3. Inlined files need to fit in 1/8 of a block to avoid metadata overflow issues, this is after limiting by metadata_max, so <= min(metadata_max, block_size)/8 By default, the largest possible inline_max is used. This preserves backwards compatibility and is probably a good default for most use cases. This does have the awkward effect of requiring inline_max=-1 to indicate disabled inlined files, but I don't think there's a good way around this.
Tests passed ✓, Code: 16964 B (-0.0%), Stack: 1432 B (+0.0%), Structs: 812 B (+1.0%)
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inlined files live in metadata and decrease storage requirements, but may be limited to improve metadata-related performance. This is especially important given the current plague of metadata performance.
Though decreasing
inline_maxmay make metadata more dense and increase block usage, so it's important to benchmark if optimizing for speed.The underlying limits of inlined files haven't changed:
cache_sizeattr_maxmetadata_max, so <=min(metadata_max, block_size)/8By default, the largest possible
inline_maxis used. This preserves backwards compatibility and is probably a good default for most use cases.This does have the awkward effect of requiring
inline_max=-1to indicate disabled inlined files, but I don't think there's a good way around this.