-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard): taskRun Table #829
Conversation
I will rewrite this with the new decided frontend design system. I just wanted to push what I already wrote
I will rewrite this with the new decided frontend design system. I just wanted to merge what I already wrote. |
fixed some minor bugs, ready for review now. |
Currently when clicking on the link for the taskRun it will not highlight the node as you need to make another request to get the nodeName 😭. I will worry about this when rewriting the table to use the new frontend decisions we made. |
0095bdf
to
bb4f4dc
Compare
@HazimAr if we are going to split the task in 2, please could you create a new issue for that particular enhancement? so we don't lose track. I think you should take that work as soon as this ticket is done. |
dashboard/src/app/(authenticated)/(diagram)/components/Diagram.tsx
Outdated
Show resolved
Hide resolved
dashboard/src/app/(authenticated)/taskDef/[name]/actions/searchTaskRun.ts
Outdated
Show resolved
Hide resolved
dashboard/src/app/(authenticated)/taskDef/[name]/components/TaskDef.tsx
Outdated
Show resolved
Hide resolved
dashboard/src/app/(authenticated)/taskDef/[name]/components/TaskDef.tsx
Outdated
Show resolved
Hide resolved
dashboard/src/app/(authenticated)/taskDef/[name]/components/TaskDef.tsx
Outdated
Show resolved
Hide resolved
This reverts commit bb4f4dc.
e9197aa
to
df5d53b
Compare
will do |
No description provided.