Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): taskRun Table #829

Merged
merged 14 commits into from
May 27, 2024
Merged

feat(dashboard): taskRun Table #829

merged 14 commits into from
May 27, 2024

Conversation

HazimAr
Copy link
Contributor

@HazimAr HazimAr commented May 24, 2024

No description provided.

@HazimAr
Copy link
Contributor Author

HazimAr commented May 24, 2024

I will rewrite this with the new decided frontend design system. I just wanted to merge what I already wrote.

@HazimAr
Copy link
Contributor Author

HazimAr commented May 24, 2024

fixed some minor bugs, ready for review now.

@HazimAr
Copy link
Contributor Author

HazimAr commented May 25, 2024

Currently when clicking on the link for the taskRun it will not highlight the node as you need to make another request to get the nodeName 😭. I will worry about this when rewriting the table to use the new frontend decisions we made.

@diablouma
Copy link
Member

Currently when clicking on the link for the taskRun it will not highlight the node as you need to make another request to get the nodeName 😭. I will worry about this when rewriting the table to use the new frontend decisions we made.

@HazimAr if we are going to split the task in 2, please could you create a new issue for that particular enhancement? so we don't lose track. I think you should take that work as soon as this ticket is done.

@HazimAr
Copy link
Contributor Author

HazimAr commented May 27, 2024

Currently when clicking on the link for the taskRun it will not highlight the node as you need to make another request to get the nodeName 😭. I will worry about this when rewriting the table to use the new frontend decisions we made.

@HazimAr if we are going to split the task in 2, please could you create a new issue for that particular enhancement? so we don't lose track. I think you should take that work as soon as this ticket is done.

will do

@HazimAr HazimAr changed the title feat: taskRun Table feat(dashboard): taskRun Table May 27, 2024
@HazimAr HazimAr merged commit 3dd149e into master May 27, 2024
15 checks passed
@HazimAr HazimAr deleted the fix/dashboard-ui-cleanup branch May 27, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants