[arch][arm-m] simplify context switch #382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The context switch is now always performed inside the PendSV handler, which greatly simplifies the code by reducing all switches to a single path. This should also eliminate any race conditions during the switch. Because we always enter PendSV for a switch, there is a slight performance penalty in the case of switching from a non-preempted thread to another non-preempted thread (~40 cycles longer on an M4, compared to the previous implementation)
|
Very interesting, we talked about this before and I'm excited to see how well this works! |
|
I pulled it in after some amount of testing. Seems to work here, though going to test a bit more on FPU based cortexes. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The context switch is now always performed inside the PendSV handler, which greatly simplifies the code by reducing all switches to a single path. This should also eliminate any race conditions during the switch.
Because we always enter PendSV for a switch, there is a slight performance penalty in the case of switching from a non-preempted thread to another non-preempted thread (~40 cycles longer on an M4, compared to the previous implementation)