[arch][arm64] Fix mmu_unmap issue when FEAT_TTL is implemented #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Precisely set bits [55:22] of the vaddress in bits [43:0] for the vae1is and vaee1is TLBI commands. On platforms where FEAT_TLL is implemented, bits [47:44] of the command accept a TTL parameter which can optionally be set to hint the translation table level containing the address being invalidated. Implementations aren't architecturally required to perform the invalidation if the hint is incorrect however. Invalidations may therefore fail with the current implementation if the vaddress has bits set in [58:55]. This is notably an issue on ARM fastmodels which doesn't perform the invalidation when the TTL parameter is incorrect.
shavitmichael
force-pushed
the
tlbi_fix_upstream
branch
from
c0c5d28
to
64e2f8a
Compare
|
Light ping :) @travisg |
|
Good catch! Sorry for the delay on this one, I totally missed it in my email spew. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precisely set bits [55:22] of the vaddress in bits [43:0] for the vae1is and vaee1is TLBI commands.
On platforms where FEAT_TLL is implemented, bits [47:44] of the command accept a TTL parameter which can optionally be set to hint the translation table level containing the address being invalidated. Implementations aren't architecturally required to perform the invalidation if the hint is incorrect however. Invalidations may therefore fail with the current implementation if the vaddress has bits set in [58:55].
This is notably an issue on ARM fastmodels which doesn't perform the invalidation when the TTL parameter is incorrect.