Skip to content

Commit

Permalink
Added mssing return type hints and made newly added class final
Browse files Browse the repository at this point in the history
  • Loading branch information
FelixJacobi committed Mar 3, 2024
1 parent f211b4d commit 7fbc727
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/Parameters/HooksListParameters.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
* @method string getMeetingID()
* @method $this setMeetingID(string $id)
*/
class HooksListParameters extends MetaParameters
final class HooksListParameters extends MetaParameters
{
/**
* @var string
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/Parameters/HooksListParametersTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

final class HooksListParametersTest extends TestCase
{
public function testHooksListParameters()
public function testHooksListParameters(): void
{
$hooksListParameters = new HooksListParameters();

Expand Down
4 changes: 2 additions & 2 deletions tests/unit/Responses/HooksDestroyResponseTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public function testHooksDestroyResponseTypes()
$this->assertEachGetterValueIsBoolean($this->destroyResponse, ['removed']);
}

public function testHookDestroyMissingHook()
public function testHookDestroyMissingHook(): void
{
$xml = simplexml_load_string('<response><returncode>FAILED</returncode><messageKey>destroyMissingHook</messageKey><message>The hook informed was not found.</message></response>');

Expand All @@ -59,7 +59,7 @@ public function testHookDestroyMissingHook()
$this->assertTrue($destroyResponse->isMissingHook());
}

public function testHookDestroyHookError()
public function testHookDestroyHookError(): void
{
$xml = simplexml_load_string('<response><returncode>FAILED</returncode><messageKey>destroyHookError</messageKey><message>An error happened while removing your hook. Check the logs.</message></response>');

Expand Down

0 comments on commit 7fbc727

Please sign in to comment.