Update Webhook api calls #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be part of 5.x due to the BC |
Merged
FelixJacobi
approved these changes
Feb 27, 2024
|
Ok, we must start a 5.4 branch based on 5.3 then and merge this up to master later after merging this PR to that one. |
FelixJacobi
reviewed
Feb 27, 2024
src/BigBlueButton.php
Outdated
| } | ||
|
|
||
| public function hooksList(): HooksListResponse | ||
| public function hooksList(HooksListParameters $hooksListParameters): HooksListResponse |
There was a problem hiding this comment.
Hm, that is a breaking change, this parameter must not be a real parameter in 5.x and this method must trigger a deprecation notice when it is missing.
src/BigBlueButton.php
Outdated
| @@ -418,14 +419,14 @@ public function hooksCreate(HooksCreateParameters $hookCreateParams): HooksCreat | |||
| return new HooksCreateResponse($xml); | |||
| } | |||
|
|
|||
| public function getHooksListUrl(): string | |||
| public function getHooksListUrl(HooksListParameters $hooksListParameters): string | |||
There was a problem hiding this comment.
Hm, that is a breaking change, this parameter must not be a real parameter in 5.x and this method must trigger a deprecation notice when it is missing.
…leredbutton/bigbluebutton-api-php into 183-add-filter-to-hook-list
FelixJacobi
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #183
HooksListParametersclass as required parameter forhooksList()andgetHooksListUrl()(Breaking Change) (see https://docs.bigbluebutton.org/development/webhooks/#hookslist)getEventID()/setEventID(string $id)on HooksCreateParameters (see https://docs.bigbluebutton.org/development/webhooks/#hookscreate)isMissingHook()andisHookError()to HooksDestroyResponse (see https://docs.bigbluebutton.org/development/webhooks/#hooksdestroy)