Better explanation of the different concepts that constitute access options #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jerome-Herbinet
force-pushed
the
Jerome-Herbinet-patch-2
branch
from
6701a9b
to
5bc7cfb
Compare
|
@ThibautPlg ; all the wording changes must be reviewed before merging. What do you think about the changes ? |
…ptions Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Jerome-Herbinet
force-pushed
the
Jerome-Herbinet-patch-2
branch
from
5bc7cfb
to
7690f8f
Compare
ThibautPlg
approved these changes
Apr 30, 2024
Looks nice to me. Translations are planned alongside? |
As soon as the new translation are sent to Transifex, I will be able to proceed to translations. By your side, I don't know if the translations upload to Transifex is automatic or not. Do you have some information ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jérôme Herbinet 33763786+Jerome-Herbinet@users.noreply.github.com
This should be a more understandable and complete description of access options.
Also, I've inserted
<br>HTML tags, but I have no idea if they can work in this context.Can reviewers test it ?