You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, all the methods we can apply to images take the same kwargs. This really doesn't make any sense.
For example, crop accepts max_width and max_height, but these have the exactly the same effect as width and height. It would make more sense to just not have them. Instead, crop could take kwargs that force an x or y offset instead of letting one be calculated (though I don't know that would be a good idea.)
Meanwhile for fit those kwargs have a different effect, but only if width or height is undefined. Really, it would make more sense to just allow width and height, but specify that one or both dimensions are loose - i.e. whether the image should be expanded to fit that dimension as best as possible or not.
The text was updated successfully, but these errors were encountered:
Right now, all the methods we can apply to images take the same kwargs. This really doesn't make any sense.
For example,
crop
accepts max_width and max_height, but these have the exactly the same effect as width and height. It would make more sense to just not have them. Instead, crop could take kwargs that force an x or y offset instead of letting one be calculated (though I don't know that would be a good idea.)Meanwhile for
fit
those kwargs have a different effect, but only if width or height is undefined. Really, it would make more sense to just allow width and height, but specify that one or both dimensions are loose - i.e. whether the image should be expanded to fit that dimension as best as possible or not.The text was updated successfully, but these errors were encountered: