Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key bindings are not consistent across all providers #864

Closed
luisdavim opened this issue Aug 23, 2022 · 1 comment
Closed

Key bindings are not consistent across all providers #864

luisdavim opened this issue Aug 23, 2022 · 1 comment
Labels
question Further information is requested

Comments

@luisdavim
Copy link

Instructions: Replace the template text and remove irrelevant text (including this line)
Warning: if you don't fill this issue template and provide the reproducible steps the issue could be closed directly.

Environment (please complete the following information):

  • OS: macOS
  • (Neo)Vim version: NVIM v0.7.2
  • vim-clap version: latest
  • Have you reproduced with a minimal vimrc: yes
  • Have you updated to the latest plugin version: yes
  • Have you upgraded to/compiled the latest Rust binary: yes

Describe the bug

With some providers I can use Ctrl + v; Ctrl + x; Ctrl + t to open a split or tab, but this doesn't work for all providers.
For example, it works with files but not filler, it works with grep2 but not with coc_outline or coc_diagnostics or when using Clap with coc-references...

@luisdavim luisdavim added the bug Something isn't working label Aug 23, 2022
@liuchengxu
Copy link
Owner

Thanks for the question, this's unfortunately expected behavior for now, for clap currently only provides a default implementation for the providers whose item is file-like and the provider needs to state it explicitly (https://github.com/liuchengxu/vim-clap/blob/8e47e5b8ab/autoload/clap/provider/grep2.vim), which is not extensible.

I can imagine it can be improved in such a way that defining generic key binding traits each provider can implement on its own. However, still, not all the providers can support Ctrl-c/x/t at the end of the day as not all items make sense to be opened in a split or tab.

@liuchengxu liuchengxu added question Further information is requested and removed bug Something isn't working labels Aug 24, 2022
liuchengxu added a commit that referenced this issue Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants