Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new experimental picker preview highlight engine #1012

Merged
merged 11 commits into from
Sep 29, 2023
Merged

Conversation

liuchengxu
Copy link
Owner

With Vim native syntax highlight (space-vim-theme):

截屏2023-09-29 17 48 28

With syntect syntax highlight (Visual Studio Dark+):

截屏2023-09-29 17 47 32

In my opinion, this new highlight engine is not superior to the native vim syntax highlight with regard to the highlight quality and speed.

  • Vim's syntax theme is more sophisticated than Sublime Text's.
  • We only render the area in the window so either way is expected to be pretty fast.

This PR is a step towards #532

@liuchengxu liuchengxu merged commit cffe143 into master Sep 29, 2023
15 checks passed
@liuchengxu liuchengxu deleted the highlighter branch September 29, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant