Tempdir code tries writing to root owned path

[jrudess]

The new tempdir code in 310ca5b is trying to access a root owned path using Vim 8.1 in linux.

The problem is a missing / between the temp-directory and sha-hash so the paths end up in the form "/tmp3ab83353affetcetc"

The following patch appears to solve it for my environment which has $TMPDIR set to '/tmp'

let tmp = '/' . sha256(fnamemodify(bufname(t:vista.source.bufnr), ":p"))

[daveyarwood]

I'm experiencing this issue as well, even after updating to e08bb0b.

I can see why e08bb0b doesn't fix the issue. On my system, TMPDIR is set to a directory that doesn't have a slash on the end -- which makes sense, I think, as a convention:

$ echo $TMPDIR
/tmp/user/1000

I think the slash was added in the wrong place, i.e. vista.vim should assume that TMPDIR does not end in a slash, and prepend a slash to the route being added to it. Hopefully that makes sense.

[daveyarwood]

^ This is the symptom.

[liuchengxu]

I have pushed a commit to catch the error and fall back to the safe tempname() way. Hopefully it could fix your issue. @dav

[petobens]

When running :Vista I'm now seeing the following:

Error detected while processing function vista#[24]..vista#sidebar#Open[12]..vista#executive#ctags#Execute[2]..<SNR>168_Dispatch[12]..<SNR>168_Execute[3]..<SNR>168_ApplyExecute[1]..<SNR>168_IntoTemp:
line   38:
E121: Undefined variable: tmp
E116: Invalid arguments for function writefile
E15: Invalid expression: writefile(lines, tmp) == 0

[liuchengxu]

@petobens Can you provide a minimal vimrc? I can't reproduce.

[daveyarwood]

That commit fixes the issue for me.

[joshuarubin]

Same issue as @petobens, $TMPDIR is not set so there is nothing to catch as a result tmp is never initialized.

[liuchengxu]

Thanks @petobens @joshuarubin . Please pull the latest commit, should be fixed.

[joshuarubin]

looks good, thx

[petobens]

Thanks!