Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Japanese translation #112

Merged
merged 3 commits into from Nov 10, 2017
Merged

Update Japanese translation #112

merged 3 commits into from Nov 10, 2017

Conversation

shingo-mori
Copy link

Hi. I updated some of the Japanese translations.
Related to #27, #37.

files translated:

  • def/--LOCALE-CODE--/about.cson
  • def/--LOCALE-CODE--/context.cson
  • def/--LOCALE-CODE--/menu_darwin.cson
  • def/--LOCALE-CODE--/menu_linux.cson
  • def/--LOCALE-CODE--/menu_win32.cson
  • def/--LOCALE-CODE--/settings.cson
  • def/--LOCALE-CODE--/welcome.cson

validation

  • I've validated my translation locally by running

npm run validation -- --locale ja

@liuderchi liuderchi added the i18n ja Japanese translation label Nov 10, 2017
@liuderchi
Copy link
Owner

@shingo-uzuki Thank you so much for your Contribution 💯

I will do a quick check and this PR will be merge soon 🎉

Copy link
Owner

@liuderchi liuderchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and it's ready to Merge : )

@liuderchi
Copy link
Owner

liuderchi commented Nov 10, 2017

@shingo-uzuki These remaining Japanese translation issues is FYI and hopefully you will be interested in it 😄

TODO for my self

  • add @shingo-uzuki to Contributors list in README

@shingo-mori
Copy link
Author

Thank you for merging!
Yes, I will translate other files as well 👍

@shingo-mori shingo-mori deleted the translate_ja branch November 11, 2017 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n ja Japanese translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants