Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved translations #184

Merged
merged 3 commits into from Jun 19, 2018
Merged

Improved translations #184

merged 3 commits into from Jun 19, 2018

Conversation

silas229
Copy link
Contributor

@silas229 silas229 commented Jun 10, 2018

This PR/Translation is about #ISSUE_NUMBER.

files translated:

  • def/de/settings.cson

@liuderchi liuderchi added i18n de German translation under-review labels Jun 10, 2018
@liuderchi
Copy link
Owner

@silas229 looks like this branch has some conflicts with master branch right now
(master has changed after #181 is merged)

Would you like to update silas229:patch-1 to resolve conficts?

@liuderchi
Copy link
Owner

@silas229 I added one commit to resolve conflict. Please review it.

Copy link
Contributor

@polynoman polynoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 389 "durch editieren" should be "durch Editieren" again, to match german grammar rules.

Also Line 323 should be "deaktivieren" instead of "de-aktivieren". See: https://www.duden.de/rechtschreibung/deaktivieren

@liuderchi
Copy link
Owner

@polynoman thanks for your review and sorry for the late fixes.

Please review the latest commit 50f826d

Copy link
Contributor

@polynoman polynoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

@liuderchi
Copy link
Owner

@polynoman I will merge this first

@liuderchi liuderchi merged commit 687edf3 into liuderchi:master Jun 19, 2018
@silas229 silas229 deleted the patch-1 branch June 25, 2018 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n de German translation under-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants