Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pt-br translation. #263

Merged
merged 1 commit into from
Mar 20, 2020
Merged

Update pt-br translation. #263

merged 1 commit into from
Mar 20, 2020

Conversation

adrihime
Copy link
Contributor

@adrihime adrihime commented Mar 10, 2020

This PR/Translation is about #241.

files translated:

  • def/pt-br/about.cson
  • def/pt-br/context.cson
  • def/pt-br/menu_darwin.cson
  • def/pt-br/menu_linux.cson
  • def/pt-br/menu_win32.cson
  • def/pt-br/settings.cson
  • def/pt-br/welcome.cson

validation

  • I've validated my translation locally by running

npm run validation -- --locale pt-br

@adrihime
Copy link
Contributor Author

Just a quick question, some words we do not translate, does this affect the % of the translation?

@liuderchi
Copy link
Owner

@adriel83 Thanks for your contribution!
Actually percentage of translation is not an accurate number, so it's totally fine

Copy link
Owner

@liuderchi liuderchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuderchi liuderchi merged commit 8e7b828 into liuderchi:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants