-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always says mark is overwritten #11
Comments
fixed, please check it. |
That actually broke saving:
You can now only set the first mark. |
@mkleehammer , whether two manual records are considerd as duplicated is determined by Line 96 in a860fe2
|
It seems to be working now, but I really thought I tested it by trying to set the 2nd 'a' mark in a completely different buffer. Anyway, there is a related behavior that makes it feel a bit off. When it overwrites, it shows the message first, which has a delay, then pulses. I know what it is doing, but it makes it feel broken or that the pulse came out of nowhere. Swapping lines 935 & 936 fixes it. Everywhere else the pulse happens before the message. |
Thankes for reporting experience! I adjust the order of message and highight, please test it again. |
Looks great. Thanks for this package. The jump display is great, especially the inclusion of the project. I have two projects that share a ton of filenames, so that is helpful. |
Small thing, but when
binky-overwrite
is true, setting a mark always results in the message "Mark is overwritten", even if the mark did not exist before.Great package, thanks.
The text was updated successfully, but these errors were encountered: