Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always says mark is overwritten #11

Closed
mkleehammer opened this issue Oct 20, 2023 · 6 comments
Closed

Always says mark is overwritten #11

mkleehammer opened this issue Oct 20, 2023 · 6 comments

Comments

@mkleehammer
Copy link

Small thing, but when binky-overwrite is true, setting a mark always results in the message "Mark is overwritten", even if the mark did not exist before.

Great package, thanks.

@liuyinz
Copy link
Owner

liuyinz commented Oct 20, 2023

fixed, please check it.

@mkleehammer
Copy link
Author

That actually broke saving:

  • mark a - nothing in echo area, good
  • move and mark b - says mark a already exists and does not set mark b

You can now only set the first mark.

@liuyinz
Copy link
Owner

liuyinz commented Oct 20, 2023

@mkleehammer , whether two manual records are considerd as duplicated is determined by binky-distance. If you like, set it to 0, and then only marks on the same line are seen as duplicated.

(defcustom binky-distance 5

@mkleehammer
Copy link
Author

It seems to be working now, but I really thought I tested it by trying to set the 2nd 'a' mark in a completely different buffer.

Anyway, there is a related behavior that makes it feel a bit off. When it overwrites, it shows the message first, which has a delay, then pulses. I know what it is doing, but it makes it feel broken or that the pulse came out of nowhere.

Swapping lines 935 & 936 fixes it. Everywhere else the pulse happens before the message.

@liuyinz
Copy link
Owner

liuyinz commented Oct 20, 2023

Thankes for reporting experience! I adjust the order of message and highight, please test it again.

@mkleehammer
Copy link
Author

Looks great. Thanks for this package. The jump display is great, especially the inclusion of the project. I have two projects that share a ton of filenames, so that is helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants