Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monaco editor css nesting workaround #518

Merged
merged 3 commits into from
Feb 29, 2024
Merged

monaco editor css nesting workaround #518

merged 3 commits into from
Feb 29, 2024

Conversation

hatemhosny
Copy link
Collaborator

@hatemhosny hatemhosny commented Feb 26, 2024

This is a workaround to use monaco editor SCSS instead of CSS to allow support for CSS nesting, till this is supported by Monaco.
See microsoft/monaco-editor#4071

image

fixes #515

Copy link

netlify bot commented Feb 26, 2024

Deploy Preview for livecodes ready!

Name Link
🔨 Latest commit 9d88e42
🔍 Latest deploy log https://app.netlify.com/sites/livecodes/deploys/65dff3091a25f600082073f7
😎 Deploy Preview https://deploy-preview-518--livecodes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cloudflare-pages bot commented Feb 26, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9d88e42
Status: ✅  Deploy successful!
Preview URL: https://1f80b484.livecodes.pages.dev
Branch Preview URL: https://fixes.livecodes.pages.dev

View logs

@hatemhosny
Copy link
Collaborator Author

Also a noscript block is added to show a message when JavaScript is disabled.
Thank you @saidbakr for suggesting this.

image

@saidbakr
Copy link

Also a noscript block is added to show a message when JavaScript is disabled. Thank you @saidbakr for suggesting this.

image

image

@hatemhosny
Copy link
Collaborator Author

Also a noscript block is added to show a message when JavaScript is disabled. Thank you @saidbakr for suggesting this.
image

image

Nice 👌
Will do this isA
Thank you

Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hatemhosny hatemhosny merged commit 71b98d4 into develop Feb 29, 2024
14 checks passed
@hatemhosny hatemhosny deleted the fixes branch February 29, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monaco editor CSS nesting support
2 participants