Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Kino.Input #53

Merged
merged 6 commits into from
Nov 25, 2021
Merged

Introduce Kino.Input #53

merged 6 commits into from
Nov 25, 2021

Conversation

jonatanklosko
Copy link
Member

See livebook-dev/livebook#714.

Currently Kino.Input.read raises in the terminal, but we can easily improve it to read and parse input. This can be handled separately though.

lib/kino/input.ex Outdated Show resolved Hide resolved
lib/kino/input.ex Outdated Show resolved Hide resolved
lib/kino/output.ex Outdated Show resolved Hide resolved
@josevalim
Copy link
Contributor

Looks great!

Currently Kino.Input.read raises in the terminal, but we can easily improve it to read and parse input. This can be handled separately though.

Yeah, let's open up an issue!

jonatanklosko and others added 2 commits November 25, 2021 12:35
Co-authored-by: José Valim <jose.valim@dashbit.co>
@jonatanklosko jonatanklosko merged commit 4efdad9 into main Nov 25, 2021
@jonatanklosko jonatanklosko deleted the jk-inputs branch November 25, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants