Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How are we going to ship livebook? #30

Closed
josevalim opened this issue Feb 16, 2021 · 3 comments · Fixed by #77
Closed

How are we going to ship livebook? #30

josevalim opened this issue Feb 16, 2021 · 3 comments · Fixed by #77

Comments

@josevalim
Copy link
Contributor

I am thinking we can start by using escripts but we should also consider shipping a release or using bakeware in the future.

Escripts are the most convenient for Elixir developers, so we should definitely consider it. The only downside of escripts is that it can't serve assets from the "priv" directory, so we will have to embed them like we did in the live dashboard.

@josevalim josevalim changed the title How are we going to ship the livebook? How are we going to ship livebook? Feb 16, 2021
@josevalim
Copy link
Contributor Author

josevalim commented Feb 16, 2021

Oh, one of the things about the livebook escript is that we should likely support multiple modes. For example, we will add livebook server but also livebook render path/to/notebook.lmd --as [markdown | html] [--elixir | --mix | --remote NODE].

@wojtekmach
Copy link
Contributor

I think escript is a fantastic start. For much broader adoption at a later date Id consider using https://github.com/bake-bake-bake/bakeware.

@josevalim josevalim added this to the v0.1 milestone Feb 16, 2021
@josevalim
Copy link
Contributor Author

josevalim commented Feb 16, 2021

When we do this, we should probably unify def/prod config, especially because there shouldn't be many differences between them, except maybe for code reloading in dev?

The other question is how we are going to configure the escript and the view app and if we can unify it somehow. We should probably support both environment variables and command line stuff for escripts, while releases/mix supports only env vars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants