-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notebook presentation view #1852
Conversation
Thank you @aifrak, this is a really nice proof of concept. However, I would like to avoid adding another icon on the bottom right. I also was planning to generalize code zen for a while, I think we could do this: we can have a button on the bottom right, once you click it, you can choose between:
Custom mode will open up a modal where you configure what you want to show. You will have 5 options:
Code mode is a shortcut where 3 and 4 only are enabled. Presentation mode has all 5 above enabled. Thoughts @jonatanklosko? Or am I overcomplicating this? |
@josevalim options and presets sounds good to me! I think it would be annoying to always go through the modal with custom, so instead we can make custom a toggle as code/presentation and have an options button in the menu that opens up a modal or similar to configure (and the settings are persisted on the client). |
For sure, I am thinking the flow would be like this:
I think we can go into steps though. For now, we could do this: @aifrak, can you please rework this PR so, instead of adding a button to the bottom left, we use a single button which, once clicked allows you to choose between code mode and presentation mode? @aifrak @jonatanklosko any suggestions on the "root" icon? |
@josevalim we could put all the view customization under "landscape" umbrella and have this icon: or "layout" |
layout-3 or layout-5 works for me! |
@josevalim Thank your for your feedbacks! Ok for layout-5. I will rework the PR. I have few questions before starting:
From what I understand, it will look like the pictures below: |
Yes
Yes
Yes
You will be able to do this with the custom mode, so we can remove it for now.
I am not sure. Suggestions @jonatanklosko? |
@aifrak and your picture is perfect. Now that I think about it, let's keep it as "Code zen" instead of "Code mode", "Code zen" is much nicer. :) |
@josevalim Thanks for your answers! |
@josevalim Focus mode or Presentation mode works for me, presentation is closer to the end use case. I was thinking of getting rid of "mode", but it's probably fine, unless we want to be fancy and call it "Showtime" :) |
What if we call it "Views" at the root level then? We would have this:
Where "custom" can be a future PR? |
I was thinking "view" initially, but thought it points more in the direction of a separate page, while "layout" refers to the current page. I'm fine with either though. |
Let’s go with “View” then. |
I think it's ok not to show this message, since all navigation/controls work the same as in the default view, also the user will intuitively click anywhere which should make the spotlight clear. @josevalim? |
I think we can skip it for now and see how the usability goes. Once we add the Custom mode, we can leave a hint under the checkbox that says use j/k for navigation. |
This reverts commit 38ebf97.
Rework has been done. PR is ready for review. |
@aifrak thanks, we should make the modes exclusive, so when we are in code zen and click presentation mode, it should disable code zen. So instead of two flags, we can have Also, the spotlight mode doesn't work properly with Kino.JS outputs (like a chart) because those are absolutely positioned iframes, so the opacity rule doesn't concern them. This one is a bit tricky, but I can figure it out later :) |
@jonatanklosko Thank you for your feedback. I have made the view modes exclusive as requested. I did not know Kino.JS outputs were special and assumed they were like the other outputs. So as you said I let this one to you, but if you need some help, you can let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
Uffizzi Preview |
@josevalim You are welcome. I will try to dive into it when I have a bit of time. |
In the indicator group, add a button to toggle the showcase mode.
When enabled:
Demo
Reasons
Questions