Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cookie access when running in iframe #1888

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Conversation

jonatanklosko
Copy link
Member

Closes #1875. See the code comment for details.

@github-actions
Copy link

github-actions bot commented Apr 28, 2023

Uffizzi Preview deployment-23640 was deleted.

@jonatanklosko jonatanklosko merged commit 8eb93f3 into main Apr 28, 2023
6 checks passed
@jonatanklosko jonatanklosko deleted the jk-embedded-cookies branch April 28, 2023 12:50
@pentarex
Copy link

pentarex commented Jul 3, 2023

I see this warning/error div in edge browser? is there a reason for not supporting it and only firefox?

@pentarex
Copy link

pentarex commented Jul 3, 2023

with the latest release, with edge release (not sure if edge is the browser or in the terms of cutting edge) i do not have this issue anymore

@jonatanklosko
Copy link
Member Author

@pentarex the :edge docker image corresponds to the main branch. This change is not yet released as :latest, so if it works on :edge it's all good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Livebook asks to open in a new tab inside iframe on Firefox
3 participants